Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2820113002: Adds Enpass Password Manager to kAllPasswordManagerApps (Closed)

Created:
3 years, 8 months ago by pkl (ping after 24h if needed)
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds Enpass Password Manager to kAllPasswordManagerApps App: https://itunes.apple.com/us/app/enpass-password-manager/id455566716?mt=8 BUG=685094 TEST=Install Enpass app and test that extension works NOTRY=true Review-Url: https://codereview.chromium.org/2820113002 Cr-Commit-Position: refs/heads/master@{#466114} Committed: https://chromium.googlesource.com/chromium/src/+/9132013d56d23c4212c0137c270cf474871c80f0

Patch Set 1 #

Patch Set 2 : not using plist any more #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ios/chrome/browser/ui/activity_services/activity_type_util.mm View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 35 (19 generated)
pkl (ping after 24h if needed)
3 years, 8 months ago (2017-04-19 16:40:54 UTC) #4
justincohen
LGTM. (Three months earlier: https://github.com/mozilla-mobile/firefox-ios/pull/1995/files)
3 years, 8 months ago (2017-04-19 16:51:10 UTC) #5
pkl (ping after 24h if needed)
Thank you! Better late than never...
3 years, 8 months ago (2017-04-19 16:52:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820113002/20001
3 years, 8 months ago (2017-04-19 16:53:13 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/251296) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 8 months ago (2017-04-19 16:57:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820113002/20001
3 years, 8 months ago (2017-04-19 17:01:03 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/252512) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 8 months ago (2017-04-19 17:05:01 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820113002/20001
3 years, 8 months ago (2017-04-19 17:15:21 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/415309)
3 years, 8 months ago (2017-04-19 17:24:22 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820113002/20001
3 years, 8 months ago (2017-04-19 18:38:31 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/415422)
3 years, 8 months ago (2017-04-19 18:45:04 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820113002/40001
3 years, 8 months ago (2017-04-20 19:59:42 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/416798)
3 years, 8 months ago (2017-04-20 20:10:20 UTC) #28
rohitrao (ping after 24h)
lgtm
3 years, 8 months ago (2017-04-20 20:20:52 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820113002/40001
3 years, 8 months ago (2017-04-20 20:33:45 UTC) #32
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 20:39:03 UTC) #35
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9132013d56d23c4212c0137c270c...

Powered by Google App Engine
This is Rietveld 408576698