|
|
Created:
3 years, 8 months ago by pkl (ping after 24h if needed) Modified:
3 years, 8 months ago CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdds Enpass Password Manager to kAllPasswordManagerApps
App:
https://itunes.apple.com/us/app/enpass-password-manager/id455566716?mt=8
BUG=685094
TEST=Install Enpass app and test that extension works
NOTRY=true
Review-Url: https://codereview.chromium.org/2820113002
Cr-Commit-Position: refs/heads/master@{#466114}
Committed: https://chromium.googlesource.com/chromium/src/+/9132013d56d23c4212c0137c270cf474871c80f0
Patch Set 1 #Patch Set 2 : not using plist any more #Patch Set 3 : rebase #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 35 (19 generated)
Description was changed from ========== Adds Enpass Password Manager to PasswordManagerExtensions.plist App: https://itunes.apple.com/us/app/enpass-password-manager/id455566716?mt=8 BUG=685094 ========== to ========== Adds Enpass Password Manager to PasswordManagerExtensions.plist App: https://itunes.apple.com/us/app/enpass-password-manager/id455566716?mt=8 BUG=685094 TEST=Install Enpass app and test that extension works ==========
Description was changed from ========== Adds Enpass Password Manager to PasswordManagerExtensions.plist App: https://itunes.apple.com/us/app/enpass-password-manager/id455566716?mt=8 BUG=685094 TEST=Install Enpass app and test that extension works ========== to ========== Adds Enpass Password Manager to kAllPasswordManagerApps App: https://itunes.apple.com/us/app/enpass-password-manager/id455566716?mt=8 BUG=685094 TEST=Install Enpass app and test that extension works ==========
pkl@chromium.org changed reviewers: + justincohen@chromium.org
LGTM. (Three months earlier: https://github.com/mozilla-mobile/firefox-ios/pull/1995/files)
Thank you! Better late than never...
The CQ bit was checked by pkl@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by pkl@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
Description was changed from ========== Adds Enpass Password Manager to kAllPasswordManagerApps App: https://itunes.apple.com/us/app/enpass-password-manager/id455566716?mt=8 BUG=685094 TEST=Install Enpass app and test that extension works ========== to ========== Adds Enpass Password Manager to kAllPasswordManagerApps App: https://itunes.apple.com/us/app/enpass-password-manager/id455566716?mt=8 BUG=685094 TEST=Install Enpass app and test that extension works NOTRY=true ==========
The CQ bit was checked by pkl@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by pkl@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by pkl@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from justincohen@chromium.org Link to the patchset: https://codereview.chromium.org/2820113002/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
rohitrao@chromium.org changed reviewers: + rohitrao@chromium.org
lgtm
The CQ bit was checked by pkl@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492720360593260, "parent_rev": "164e4cdfd53297fe3801ae893bbaa48651e1b339", "commit_rev": "9132013d56d23c4212c0137c270cf474871c80f0"}
Message was sent while issue was closed.
Description was changed from ========== Adds Enpass Password Manager to kAllPasswordManagerApps App: https://itunes.apple.com/us/app/enpass-password-manager/id455566716?mt=8 BUG=685094 TEST=Install Enpass app and test that extension works NOTRY=true ========== to ========== Adds Enpass Password Manager to kAllPasswordManagerApps App: https://itunes.apple.com/us/app/enpass-password-manager/id455566716?mt=8 BUG=685094 TEST=Install Enpass app and test that extension works NOTRY=true Review-Url: https://codereview.chromium.org/2820113002 Cr-Commit-Position: refs/heads/master@{#466114} Committed: https://chromium.googlesource.com/chromium/src/+/9132013d56d23c4212c0137c270c... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/9132013d56d23c4212c0137c270c... |