Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2826463002: Adds Secrets Password Manager to kAllPasswordManagerApps (Closed)

Created:
3 years, 8 months ago by pkl (ping after 24h if needed)
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds Secrets Password Manager to kAllPasswordManagerApps App: https://itunes.apple.com/us/app/secrets-touch/id1018350473?mt=8 BUG=681583 TEST=Install Secrets app and test that extensions work. Review-Url: https://codereview.chromium.org/2826463002 Cr-Commit-Position: refs/heads/master@{#466123} Committed: https://chromium.googlesource.com/chromium/src/+/e02d5f6605d5ceabeb3f5cd4a84495a54e1f3fce

Patch Set 1 #

Patch Set 2 : use kAllPasswordManagerApps #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ios/chrome/browser/ui/activity_services/activity_type_util.mm View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
pkl (ping after 24h if needed)
3 years, 8 months ago (2017-04-19 16:40:37 UTC) #3
justincohen
lgtm
3 years, 8 months ago (2017-04-19 16:52:01 UTC) #4
rohitrao (ping after 24h)
lgtm
3 years, 8 months ago (2017-04-20 20:22:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826463002/40001
3 years, 8 months ago (2017-04-20 20:40:41 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 20:54:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e02d5f6605d5ceabeb3f5cd4a844...

Powered by Google App Engine
This is Rietveld 408576698