Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2820103008: Revert of v8binding: Reenable xss-DENIED-window-name-navigator test. (Closed)

Created:
3 years, 8 months ago by ojan
Modified:
3 years, 8 months ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of v8binding: Reenable xss-DENIED-window-name-navigator test. (patchset #1 id:1 of https://codereview.chromium.org/2818423002/ ) Reason for revert: virtual/mojo-loading/http/tests/security/xss-DENIED-window-name-navigator.html still fails on the retina bot, but it's not flaky at least. :) https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fmojo-loading%2Fhttp%2Ftests%2Fsecurity%2Fxss-DENIED-window-name-navigator.html&testType=webkit_tests Original issue's description: > v8binding: Reenable xss-DENIED-window-name-navigator test. > > Enables xss-DENIED-window-name-navigator test again since > https://crrev.com/2800053003 and https://crrev.com/2824753002 > should have fixed the flakiness. > > BUG=686470 > > Review-Url: https://codereview.chromium.org/2818423002 > Cr-Commit-Position: refs/heads/master@{#465166} > Committed: https://chromium.googlesource.com/chromium/src/+/011220664d3be6c6ab847371f5d5863813c321fd TBR=haraken@chromium.org,yukishiino@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=686470 Review-Url: https://codereview.chromium.org/2820103008 Cr-Commit-Position: refs/heads/master@{#465314} Committed: https://chromium.googlesource.com/chromium/src/+/32c7f299bac9dfc90dcdbc2a9273892f01ce18e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ojan
Created Revert of v8binding: Reenable xss-DENIED-window-name-navigator test.
3 years, 8 months ago (2017-04-18 19:03:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820103008/1
3 years, 8 months ago (2017-04-18 19:04:27 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/32c7f299bac9dfc90dcdbc2a9273892f01ce18e6
3 years, 8 months ago (2017-04-18 19:05:07 UTC) #6
haraken
LGTM to revert.
3 years, 8 months ago (2017-04-18 20:18:50 UTC) #7
Yuki
3 years, 8 months ago (2017-04-19 07:17:53 UTC) #8
Message was sent while issue was closed.
LGTM.

I missed something again...

Powered by Google App Engine
This is Rietveld 408576698