Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2818423002:
v8binding: Reenable xss-DENIED-window-name-navigator test. (Closed)
Descriptionv8binding: Reenable xss-DENIED-window-name-navigator test.
Enables xss-DENIED-window-name-navigator test again since
https://crrev.com/2800053003 and https://crrev.com/2824753002
should have fixed the flakiness.
BUG=686470
Review-Url: https://codereview.chromium.org/2818423002
Cr-Commit-Position: refs/heads/master@{#465166}
Committed: https://chromium.googlesource.com/chromium/src/+/011220664d3be6c6ab847371f5d5863813c321fd
Patch Set 1 #
Messages
Total messages: 18 (13 generated)
The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== v8binding: Reenable xss-DENIED-window-name-navigator test. Enables xss-DENIED-window-name-navigator test again since https://crrev.com/2800053003 should have fixed the flakiness. BUG=686470 ========== to ========== v8binding: Reenable xss-DENIED-window-name-navigator test. Enables xss-DENIED-window-name-navigator test again since https://crrev.com/2800053003 and https://crrev.com/2824753002 should have fixed the flakiness. BUG=686470 ==========
yukishiino@chromium.org changed reviewers: + haraken@chromium.org
Could you review this CL?
LGTM
The CQ bit was checked by yukishiino@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1492499447344620, "parent_rev":
"98b4ddff61ce97ba199e4ee014020402be46e830", "commit_rev":
"011220664d3be6c6ab847371f5d5863813c321fd"}
Message was sent while issue was closed.
Description was changed from ========== v8binding: Reenable xss-DENIED-window-name-navigator test. Enables xss-DENIED-window-name-navigator test again since https://crrev.com/2800053003 and https://crrev.com/2824753002 should have fixed the flakiness. BUG=686470 ========== to ========== v8binding: Reenable xss-DENIED-window-name-navigator test. Enables xss-DENIED-window-name-navigator test again since https://crrev.com/2800053003 and https://crrev.com/2824753002 should have fixed the flakiness. BUG=686470 Review-Url: https://codereview.chromium.org/2818423002 Cr-Commit-Position: refs/heads/master@{#465166} Committed: https://chromium.googlesource.com/chromium/src/+/011220664d3be6c6ab847371f5d5... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/011220664d3be6c6ab847371f5d5...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2820103008/ by ojan@chromium.org. The reason for reverting is: virtual/mojo-loading/http/tests/security/xss-DENIED-window-name-navigator.html still fails on the retina bot, but it's not flaky at least. :) https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=vi.... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
