Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2820063003: Fix NTP parentViewController. (Closed)

Created:
3 years, 8 months ago by justincohen
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix NTP parentViewController. NTP.parentViewController can be accessed during init, so setting this as a property after init is too late. BUG=708319 Review-Url: https://codereview.chromium.org/2820063003 Cr-Commit-Position: refs/heads/master@{#465232} Committed: https://chromium.googlesource.com/chromium/src/+/bc913634cadc4ac06b3637b2025129d1c513bf65

Patch Set 1 #

Patch Set 2 : DCHECK #

Patch Set 3 : DCHECK #

Patch Set 4 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -35 lines) Patch
M ios/chrome/browser/ui/browser_view_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_controller.h View 1 chunk +8 lines, -16 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_controller.mm View 1 2 4 chunks +20 lines, -7 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_controller_unittest.mm View 1 2 3 3 chunks +15 lines, -10 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
justincohen
ptal
3 years, 8 months ago (2017-04-18 12:15:34 UTC) #10
rohitrao (ping after 24h)
lgtm
3 years, 8 months ago (2017-04-18 14:35:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820063003/60001
3 years, 8 months ago (2017-04-18 14:38:12 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 14:41:59 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/bc913634cadc4ac06b3637b20251...

Powered by Google App Engine
This is Rietveld 408576698