Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: ios/chrome/browser/ui/ntp/new_tab_page_controller.h

Issue 2820063003: Fix NTP parentViewController. (Closed)
Patch Set: Fix tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/ntp/new_tab_page_controller.h
diff --git a/ios/chrome/browser/ui/ntp/new_tab_page_controller.h b/ios/chrome/browser/ui/ntp/new_tab_page_controller.h
index dcbe42e1667aa86c3816e7385dc73b73d031a787..3aaa25e96369e9c04e0ec8a615b83e7cd8ad0502 100644
--- a/ios/chrome/browser/ui/ntp/new_tab_page_controller.h
+++ b/ios/chrome/browser/ui/ntp/new_tab_page_controller.h
@@ -85,27 +85,19 @@ std::string FragmentFromIdentifier(PanelIdentifier panel);
@property(nonatomic, assign) id<CRWSwipeRecognizerProvider>
swipeRecognizerProvider;
-// To ease modernizing the NTP only the internal panels are being converted
-// to UIViewControllers. This means all the plumbing between the
-// BrowserViewController and the internal NTP panels (WebController, NTP)
-// hierarchy is skipped. While normally the logic to push and pop a view
-// controller would be owned by a coordinator, in this case the old NTP
-// controller adds and removes child view controllers itself when a load
-// is initiated, and when WebController calls -willBeDismissed.
-@property(nonatomic, assign) UIViewController* parentViewController;
-
// Init with the given url (presumably "chrome://newtab") and loader object.
// |loader| may be nil, but isn't retained so it must outlive this controller.
// Dominant color cache is passed to bookmark controller only, to optimize
// favicon processing.
- (id)initWithUrl:(const GURL&)url
- loader:(id<UrlLoader>)loader
- focuser:(id<OmniboxFocuser>)focuser
- ntpObserver:(id<NewTabPageControllerObserver>)ntpObserver
- browserState:(ios::ChromeBrowserState*)browserState
- colorCache:(NSMutableDictionary*)colorCache
- webToolbarDelegate:(id<WebToolbarDelegate>)webToolbarDelegate
- tabModel:(TabModel*)tabModel;
+ loader:(id<UrlLoader>)loader
+ focuser:(id<OmniboxFocuser>)focuser
+ ntpObserver:(id<NewTabPageControllerObserver>)ntpObserver
+ browserState:(ios::ChromeBrowserState*)browserState
+ colorCache:(NSMutableDictionary*)colorCache
+ webToolbarDelegate:(id<WebToolbarDelegate>)webToolbarDelegate
+ tabModel:(TabModel*)tabModel
+ parentViewController:(UIViewController*)parentViewController;
// Select a panel based on the given |panelType|.
- (void)selectPanel:(NewTabPage::PanelIdentifier)panelType;
« no previous file with comments | « ios/chrome/browser/ui/browser_view_controller.mm ('k') | ios/chrome/browser/ui/ntp/new_tab_page_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698