Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Issue 2819593002: Revert of Expose resources in Robolectric/JUnit tests. (Closed)

Created:
3 years, 8 months ago by mikecase (-- gone --)
Modified:
3 years, 8 months ago
Reviewers:
nyquist, jbudorick, agrieve, dgn
CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Expose resources in Robolectric/JUnit tests. (patchset #12 id:220001 of https://codereview.chromium.org/2767613002/ ) Reason for revert: crbug/711372 Original issue's description: > Expose resources in Robolectric/JUnit tests. > > BUG=693573 > > Review-Url: https://codereview.chromium.org/2767613002 > Cr-Commit-Position: refs/heads/master@{#464422} > Committed: https://chromium.googlesource.com/chromium/src/+/0d81d90a4b60f8dbcf75f92405cb441db3d08cd3 TBR=agrieve@chromium.org,dgn@chromium.org,jbudorick@chromium.org,nyquist@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=693573 Review-Url: https://codereview.chromium.org/2819593002 Cr-Commit-Position: refs/heads/master@{#464486} Committed: https://chromium.googlesource.com/chromium/src/+/b67ca3636e3ec5dc8f38a1ffd9db79a1208620e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -200 lines) Patch
M build/android/gyp/create_test_runner_script.py View 3 chunks +0 lines, -16 lines 0 comments Download
M build/android/gyp/write_build_config.py View 2 chunks +1 line, -3 lines 0 comments Download
M build/android/pylib/junit/junit_test_instance.py View 2 chunks +0 lines, -20 lines 0 comments Download
M build/android/pylib/local/machine/local_machine_junit_test_run.py View 4 chunks +16 lines, -46 lines 0 comments Download
M build/android/test_runner.py View 1 chunk +0 lines, -15 lines 0 comments Download
M build/android/test_runner.pydeps View 1 chunk +0 lines, -1 line 0 comments Download
M build/config/android/internal_rules.gni View 2 chunks +1 line, -31 lines 0 comments Download
M build/config/android/rules.gni View 3 chunks +0 lines, -18 lines 0 comments Download
M chrome/android/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java View 5 chunks +56 lines, -1 line 0 comments Download
M testing/android/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M testing/android/junit/java/src/org/chromium/testing/local/GNManifestFactory.java View 1 chunk +11 lines, -40 lines 0 comments Download
M testing/android/junit/java/src/org/chromium/testing/local/LocalRobolectricTestRunner.java View 2 chunks +1 line, -5 lines 0 comments Download
M third_party/robolectric/README.chromium View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
mikecase (-- gone --)
Created Revert of Expose resources in Robolectric/JUnit tests.
3 years, 8 months ago (2017-04-13 18:02:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819593002/1
3 years, 8 months ago (2017-04-13 18:03:49 UTC) #3
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 8 months ago (2017-04-13 18:43:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819593002/1
3 years, 8 months ago (2017-04-13 18:55:46 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 19:00:59 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b67ca3636e3ec5dc8f38a1ffd9db...

Powered by Google App Engine
This is Rietveld 408576698