Migrate GpuChildThread to use ConnectionFilter instead of the ChildThread's InterfaceRegistry to exp

Migrate GpuChildThread to use ConnectionFilter instead of the ChildThread's InterfaceRegistry to expose interfaces on incoming connections.

R=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2819903004
Cr-Commit-Position: refs/heads/master@{#466806}
Committed: https://chromium.googlesource.com/chromium/src/+/d623444f8f4423798526f5f596ab10d892b74308

[Ben Goodger (Google), 2017-04-14 23:03:54]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 23:04:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Goodger (Google), 2017-04-14 23:12:05]

Description was changed from

==========
Migrate GpuChildThread to use ConnectionFilter instead of the ChildThread's
InterfaceRegistry to expose interfaces on incoming connections.

R=rockot@chromium.org
==========

to

==========
Migrate GpuChildThread to use ConnectionFilter instead of the ChildThread's
InterfaceRegistry to expose interfaces on incoming connections.

R=rockot@chromium.org
==========

[commit-bot: I haz the power, 2017-04-14 23:15:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 23:15:43]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Ben Goodger (Google), 2017-04-14 23:16:50]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 23:17:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Goodger (Google), 2017-04-14 23:24:10]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 23:24:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 23:29:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 23:29:44]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2017-04-15 02:49:53]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-15 02:50:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-15 03:04:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-15 03:04:01]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Ben Goodger (Google), 2017-04-15 03:20:23]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-15 03:20:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-15 03:30:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-15 03:30:02]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2017-04-16 06:30:38]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-16 06:30:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-16 06:43:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-16 06:43:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2017-04-16 06:47:54]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-16 06:48:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-16 06:59:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-16 06:59:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2017-04-16 07:04:08]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-16 07:04:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-16 08:49:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-16 08:49:07]

Dry run: This issue passed the CQ dry run.

[Ben Goodger (Google), 2017-04-19 00:14:25]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[Ben Goodger (Google), 2017-04-19 00:15:03]

ok how about now

[commit-bot: I haz the power, 2017-04-19 00:15:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 01:02:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 01:02:48]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Ken Rockot(use gerrit already), 2017-04-19 01:26:30]

Hmm, this definitely won't work.

CreateGpuService can't be invoked until the IPC Channel is set up. The IPC
Channel can't be set up until the ServiceManagerConnection is started - the
browser binds to the IPC::mojom::ChannelBootstrap interface, which is handled by
a ConnectionFilter in the child
(https://cs.chromium.org/chromium/src/content/child/child_thread_impl.cc?rcl=1...)

https://codereview.chromium.org/2819903004/diff/160001/content/gpu/gpu_child_...
File content/gpu/gpu_child_thread.cc (right):

https://codereview.chromium.org/2819903004/diff/160001/content/gpu/gpu_child_...
content/gpu/gpu_child_thread.cc:78: .InBrowserProcess(params)
Need to turn off autostart for this constructor as well

[Ben Goodger (Google), 2017-04-19 04:34:53]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 04:35:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Goodger (Google), 2017-04-19 04:38:40]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[Ben Goodger (Google), 2017-04-19 04:38:49]

OK what about this

[commit-bot: I haz the power, 2017-04-19 04:38:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 04:49:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 04:49:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Ben Goodger (Google), 2017-04-19 05:09:41]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 05:10:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 05:19:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 05:19:50]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Ben Goodger (Google), 2017-04-19 06:03:36]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 06:04:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 06:18:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 06:18:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2017-04-19 13:44:09]

On 2017/04/19 04:38:49, Ben Goodger (Google) wrote:
> OK what about this

yeah ok let me refix the red

[Ben Goodger (Google), 2017-04-19 22:00:09]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 22:01:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 22:16:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 22:16:06]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Ben Goodger (Google), 2017-04-19 22:44:28]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 22:45:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 23:04:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 23:04:15]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Ben Goodger (Google), 2017-04-19 23:23:56]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 23:24:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 23:45:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 23:45:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2017-04-19 23:56:39]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 23:57:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 00:21:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 00:21:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2017-04-20 15:30:22]

https://codereview.chromium.org/2819903004/diff/200001/chrome/gpu/chrome_cont...
File chrome/gpu/chrome_content_gpu_client.h (right):

https://codereview.chromium.org/2819903004/diff/200001/chrome/gpu/chrome_cont...
chrome/gpu/chrome_content_gpu_client.h:21: void
Initialize(base::FieldTrialList::Observer* observer) override;
need to update the signature here

https://codereview.chromium.org/2819903004/diff/320001/content/gpu/gpu_child_...
File content/gpu/gpu_child_thread.cc (right):

https://codereview.chromium.org/2819903004/diff/320001/content/gpu/gpu_child_...
content/gpu/gpu_child_thread.cc:85: base::WeakPtr<QueueingConnectionFilter>
GetWeakPtr() {
WeakPtr must be dereferenced and invalidated from the same thread - you're
expecting to use a WeakPtr on one thread while invalidating it on another.
Instead of doing that, how about binding a callback to Release on the IO thread
which uses a WeakPtr, and just having GpuChildThread hold and invoke the
callback.

Then you don't have to expose a public GetWeakPtr method, and the WeakPtr will
always be dereferenced only on the IO thread where it's also invalidated.

It's a little ugly:

base::Closure GetReleaseCallback() {
  return base::Bind(base::IgnoreResult(&base::TaskRunner::PostTask),
                    io_task_runner_, FROM_HERE,
                    base::Bind(&QueueingConnectionFilter::Release,
                               weak_factory_.GetWeakPtr()));
}

but I think safe.

[Ken Rockot(use gerrit already), 2017-04-20 15:30:51]

On 2017/04/20 at 15:30:22, Ken Rockot wrote:
>
https://codereview.chromium.org/2819903004/diff/200001/chrome/gpu/chrome_cont...
> File chrome/gpu/chrome_content_gpu_client.h (right):
> 
>
https://codereview.chromium.org/2819903004/diff/200001/chrome/gpu/chrome_cont...
> chrome/gpu/chrome_content_gpu_client.h:21: void
Initialize(base::FieldTrialList::Observer* observer) override;
> need to update the signature here

oops, old comment plz ignore

> 
>
https://codereview.chromium.org/2819903004/diff/320001/content/gpu/gpu_child_...
> File content/gpu/gpu_child_thread.cc (right):
> 
>
https://codereview.chromium.org/2819903004/diff/320001/content/gpu/gpu_child_...
> content/gpu/gpu_child_thread.cc:85: base::WeakPtr<QueueingConnectionFilter>
GetWeakPtr() {
> WeakPtr must be dereferenced and invalidated from the same thread - you're
expecting to use a WeakPtr on one thread while invalidating it on another.
Instead of doing that, how about binding a callback to Release on the IO thread
which uses a WeakPtr, and just having GpuChildThread hold and invoke the
callback.
> 
> Then you don't have to expose a public GetWeakPtr method, and the WeakPtr will
always be dereferenced only on the IO thread where it's also invalidated.
> 
> It's a little ugly:
> 
> base::Closure GetReleaseCallback() {
>   return base::Bind(base::IgnoreResult(&base::TaskRunner::PostTask),
>                     io_task_runner_, FROM_HERE,
>                     base::Bind(&QueueingConnectionFilter::Release,
>                                weak_factory_.GetWeakPtr()));
> }
> 
> but I think safe.

[Ben Goodger (Google), 2017-04-20 16:21:37]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 16:22:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Goodger (Google), 2017-04-20 16:33:27]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 16:33:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Goodger (Google), 2017-04-20 17:13:28]

OK how 'bout now.

[commit-bot: I haz the power, 2017-04-20 17:38:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 17:38:54]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ken Rockot(use gerrit already), 2017-04-20 17:41:45]

LGTM just nits. Might be worth asking piman@ to take a look too as GPU owner

https://codereview.chromium.org/2819903004/diff/360001/content/gpu/gpu_child_...
File content/gpu/gpu_child_thread.cc (right):

https://codereview.chromium.org/2819903004/diff/360001/content/gpu/gpu_child_...
content/gpu/gpu_child_thread.cc:216: release_closure_ =
filter->GetReleaseCallback();
nit: Maybe a better name than release_closure_ since in the context of
GpuChildThread in general that's pretty ambigious?

https://codereview.chromium.org/2819903004/diff/360001/content/gpu/gpu_child_...
File content/gpu/gpu_child_thread.h (right):

https://codereview.chromium.org/2819903004/diff/360001/content/gpu/gpu_child_...
content/gpu/gpu_child_thread.h:75: class QueueingConnectionFilter;
Does this really need to be a nested class declaration? I think it can just be
defined entirely in an anonymous namespace in the cc?

[Ben Goodger (Google), 2017-04-20 18:27:18]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2017-04-20 18:27:25]

The CQ bit was unchecked by ben@chromium.org

[Ben Goodger (Google), 2017-04-20 19:14:57]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2017-04-20 19:14:57]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2819903004/#ps380001
(title: ".")

[commit-bot: I haz the power, 2017-04-20 19:15:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 19:27:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 19:27:29]

Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2017-04-20 19:42:16]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2017-04-20 19:42:16]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2819903004/#ps400001
(title: ".")

[commit-bot: I haz the power, 2017-04-20 19:43:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 21:21:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 21:21:58]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ben Goodger (Google), 2017-04-20 22:31:25]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2017-04-20 22:31:26]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2819903004/#ps420001
(title: ".")

[commit-bot: I haz the power, 2017-04-20 22:32:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 22:35:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 22:35:17]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Ben Goodger (Google), 2017-04-20 23:34:51]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2017-04-20 23:35:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 01:01:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 01:01:17]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ben Goodger (Google), 2017-04-24 19:16:05]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 19:17:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Goodger (Google), 2017-04-24 19:23:41]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 19:24:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Goodger (Google), 2017-04-24 20:28:35]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 20:29:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 21:35:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 21:35:57]

Dry run: This issue passed the CQ dry run.

[Ben Goodger (Google), 2017-04-24 21:40:59]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2017-04-24 21:41:00]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2819903004/#ps500001
(title: ".")

[commit-bot: I haz the power, 2017-04-24 21:41:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 22:51:22]

CQ is committing da patch.

Bot data: {"patchset_id": 500001, "attempt_start_ts": 1493070059894480,
"parent_rev": "bab199c9ccd8b873ac9d3c2e68ad79607887263c", "commit_rev":
"d623444f8f4423798526f5f596ab10d892b74308"}

[commit-bot: I haz the power, 2017-04-24 22:51:36]

Description was changed from

==========
Migrate GpuChildThread to use ConnectionFilter instead of the ChildThread's
InterfaceRegistry to expose interfaces on incoming connections.

R=rockot@chromium.org
==========

to

==========
Migrate GpuChildThread to use ConnectionFilter instead of the ChildThread's
InterfaceRegistry to expose interfaces on incoming connections.

R=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2819903004
Cr-Commit-Position: refs/heads/master@{#466806}
Committed:
https://chromium.googlesource.com/chromium/src/+/d623444f8f4423798526f5f596ab...
==========

[commit-bot: I haz the power, 2017-04-24 22:51:37]

Committed patchset #26 (id:500001) as
https://chromium.googlesource.com/chromium/src/+/d623444f8f4423798526f5f596ab...