Remove usage of Tab's |url| property from NewTabPageUMA utilities.

Remove usage of Tab's |url| property from NewTabPageUMA utilities.

BUG=546208
Review-Url: https://codereview.chromium.org/2819903002
Cr-Commit-Position: refs/heads/master@{#476169}
Committed: https://chromium.googlesource.com/chromium/src/+/17c57e62c598b8c3604ed66f277b65c04b13eea8

[kkhorimoto, 2017-04-14 20:32:15]

remove uneccessary include

[kkhorimoto, 2017-04-14 20:33:22]

lastCommitted => visible

[kkhorimoto, 2017-04-14 20:34:33]

kkhorimoto@chromium.org changed reviewers:
+ eugenebut@chromium.org, rohitrao@chromium.org, sdefresne@chromium.org

[kkhorimoto, 2017-04-14 20:34:34]

https://codereview.chromium.org/2819903002/diff/40001/ios/chrome/browser/metr...
File ios/chrome/browser/metrics/new_tab_page_uma.mm (right):

https://codereview.chromium.org/2819903002/diff/40001/ios/chrome/browser/metr...
ios/chrome/browser/metrics/new_tab_page_uma.mm:22:
tab_model.currentTab.visibleURL == GURL(kChromeUINewTabURL);
The old behavior would return a non-NTP URL if there was any navigation
occurring at all.  This updates the implementation slightly to return the
non-NTP URL only if there's a user-initiated load.

[Eugene But (OOO till 7-30), 2017-04-14 21:43:03]

https://codereview.chromium.org/2819903002/diff/40001/ios/chrome/browser/metr...
File ios/chrome/browser/metrics/new_tab_page_uma.mm (right):

https://codereview.chromium.org/2819903002/diff/40001/ios/chrome/browser/metr...
ios/chrome/browser/metrics/new_tab_page_uma.mm:22:
tab_model.currentTab.visibleURL == GURL(kChromeUINewTabURL);
On 2017/04/14 20:34:33, kkhorimoto_ wrote:
> The old behavior would return a non-NTP URL if there was any navigation
> occurring at all.  This updates the implementation slightly to return the
> non-NTP URL only if there's a user-initiated load.
Should this be lastCommittedURL? I think that old code was not correct.

[kkhorimoto, 2017-05-31 22:58:33]

https://codereview.chromium.org/2819903002/diff/40001/ios/chrome/browser/metr...
File ios/chrome/browser/metrics/new_tab_page_uma.mm (right):

https://codereview.chromium.org/2819903002/diff/40001/ios/chrome/browser/metr...
ios/chrome/browser/metrics/new_tab_page_uma.mm:22:
tab_model.currentTab.visibleURL == GURL(kChromeUINewTabURL);
On 2017/04/14 21:43:02, Eugene But wrote:
> On 2017/04/14 20:34:33, kkhorimoto_ wrote:
> > The old behavior would return a non-NTP URL if there was any navigation
> > occurring at all.  This updates the implementation slightly to return the
> > non-NTP URL only if there's a user-initiated load.
> Should this be lastCommittedURL? I think that old code was not correct.

For user-initiated loads, the web view will be shown immediately and the NTP
will be removed as soon as the pending item is created.  Thus, if the visible
item's URL is not the NTP, then the NTP is not currently being displayed.  For
renderer-initiated loads, the web view will be shown only after the load is
committed.  Using the visible URL makes sense to me because it's tightly coupled
to whether the NTP or the webview is currently displayed.

[Eugene But (OOO till 7-30), 2017-05-31 23:43:50]

lgtm

[kkhorimoto, 2017-06-01 03:16:13]

The CQ bit was checked by kkhorimoto@chromium.org

[commit-bot: I haz the power, 2017-06-01 03:16:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 03:26:31]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496286973740100,
"parent_rev": "64c801e7a62896e59ab8337ae53dd10c8b4d7126", "commit_rev":
"17c57e62c598b8c3604ed66f277b65c04b13eea8"}

[commit-bot: I haz the power, 2017-06-01 03:26:41]

Description was changed from

==========
Remove usage of Tab's |url| property from NewTabPageUMA utilities.

BUG=546208
==========

to

==========
Remove usage of Tab's |url| property from NewTabPageUMA utilities.

BUG=546208

Review-Url: https://codereview.chromium.org/2819903002
Cr-Commit-Position: refs/heads/master@{#476169}
Committed:
https://chromium.googlesource.com/chromium/src/+/17c57e62c598b8c3604ed66f277b...
==========

[commit-bot: I haz the power, 2017-06-01 03:26:42]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/17c57e62c598b8c3604ed66f277b...