Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Issue 2819823002: Revert of Update Python style guide to point out exceptions only apply to legacy scripts (Closed)

Created:
3 years, 8 months ago by Nico
Modified:
3 years, 8 months ago
Reviewers:
brettw, ktyliu
CC:
chromium-reviews, danakj+watch_chromium.org, jbroman+cpp_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update Python style guide to point out exceptions only apply to legacy scripts (patchset #3 id:40001 of https://codereview.chromium.org/2626863005/ ) Reason for revert: This doesn't only apply to legacy scripts; revert pending real discussion somewhere. Original issue's description: > Update Python style guide to point out exceptions only apply to legacy scripts > > Review-Url: https://codereview.chromium.org/2626863005 > Cr-Commit-Position: refs/heads/master@{#444608} > Committed: https://chromium.googlesource.com/chromium/src/+/27e7d60bc5bb4afb081116e39905aa66e7cf2489 TBR=brettw@chromium.org,ktyliu@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2819823002 Cr-Commit-Position: refs/heads/master@{#464725} Committed: https://chromium.googlesource.com/chromium/src/+/3dcdf861ebac234cefd56a8c6b488b628b77edd3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M styleguide/styleguide.md View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Nico
Created Revert of Update Python style guide to point out exceptions only apply to legacy ...
3 years, 8 months ago (2017-04-14 14:15:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819823002/1
3 years, 8 months ago (2017-04-14 14:15:55 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 14:25:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3dcdf861ebac234cefd56a8c6b48...

Powered by Google App Engine
This is Rietveld 408576698