Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Issue 2626863005: Update Python style guide to point out exceptions only apply to legacy scripts (Closed)

Created:
3 years, 11 months ago by ktyliu
Modified:
3 years, 8 months ago
Reviewers:
brettw, Nico
CC:
chromium-reviews, danakj+watch_chromium.org, jbroman+cpp_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Python style guide to point out exceptions only apply to legacy scripts Review-Url: https://codereview.chromium.org/2626863005 Cr-Commit-Position: refs/heads/master@{#444608} Committed: https://chromium.googlesource.com/chromium/src/+/27e7d60bc5bb4afb081116e39905aa66e7cf2489

Patch Set 1 #

Total comments: 1

Patch Set 2 : follow->following #

Patch Set 3 : New scripts should be PEP-8 compliant #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M styleguide/styleguide.md View 1 2 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 23 (6 generated)
ktyliu
Hi Brett, I would like to tweak the wording of the Python part of the ...
3 years, 11 months ago (2017-01-13 00:30:12 UTC) #2
danakj
drive-by typo finder https://codereview.chromium.org/2626863005/diff/1/styleguide/styleguide.md File styleguide/styleguide.md (right): https://codereview.chromium.org/2626863005/diff/1/styleguide/styleguide.md#newcode19 styleguide/styleguide.md:19: Some parts of the Chromium codebase ...
3 years, 11 months ago (2017-01-13 17:15:23 UTC) #3
ktyliu
On 2017/01/13 at 17:15:23, danakj wrote: > drive-by typo finder > > https://codereview.chromium.org/2626863005/diff/1/styleguide/styleguide.md > File ...
3 years, 11 months ago (2017-01-15 21:42:37 UTC) #4
brettw
How does one know where such exceptions apply?
3 years, 11 months ago (2017-01-17 20:53:15 UTC) #5
ktyliu
On 2017/01/17 at 20:53:15, brettw wrote: > How does one know where such exceptions apply? ...
3 years, 11 months ago (2017-01-17 21:33:38 UTC) #6
brettw
For context, I didn't write the style guide here, I copied it from the sites ...
3 years, 11 months ago (2017-01-18 22:22:23 UTC) #7
ktyliu
On 2017/01/18 at 22:22:23, brettw wrote: > For context, I didn't write the style guide ...
3 years, 11 months ago (2017-01-18 23:41:19 UTC) #8
brettw
lgtm
3 years, 11 months ago (2017-01-19 01:15:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626863005/40001
3 years, 11 months ago (2017-01-19 02:37:33 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/27e7d60bc5bb4afb081116e39905aa66e7cf2489
3 years, 11 months ago (2017-01-19 02:50:40 UTC) #15
Nico
Was this discussed or announced somewhere? I happened to see this by coincidence today, and ...
3 years, 8 months ago (2017-04-06 14:33:26 UTC) #17
Nico
3019 hits for 2 indent: https://cs.chromium.org/search/?q=f:src/.*py$+%5Cn%5CS.*:%5Cn%5C+%5C+%5CS+pcre:yes+-file:third_party&all=1&type=cs 79 hits for 4 indent: https://cs.chromium.org/search/?q=f:src/.*py$+%5Cn%5CS.*:%5Cn%5C+%5C+%5C+%5C+%5CS+pcre:yes+-file:third_party&all=1&type=cs So this change ...
3 years, 8 months ago (2017-04-06 14:38:51 UTC) #18
Nico
On 2017/04/06 14:38:51, Nico wrote: > 3019 hits for 2 indent: > https://cs.chromium.org/search/?q=f:src/.*py$+%5Cn%5CS.*:%5Cn%5C+%5C+%5CS+pcre:yes+-file:third_party&all=1&type=cs > > ...
3 years, 8 months ago (2017-04-11 16:59:02 UTC) #19
ktyliu_google
On 2017/04/06 14:38:51, Nico wrote: > 3019 hits for 2 indent: > https://cs.chromium.org/search/?q=f:src/.*py$+%5Cn%5CS.*:%5Cn%5C+%5C+%5CS+pcre:yes+-file:third_party&all=1&type=cs > > ...
3 years, 8 months ago (2017-04-14 06:24:56 UTC) #20
Nico
On 2017/04/14 06:24:56, ktyliu_google wrote: > On 2017/04/06 14:38:51, Nico wrote: > > 3019 hits ...
3 years, 8 months ago (2017-04-14 14:14:59 UTC) #21
Nico
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2819823002/ by thakis@chromium.org. ...
3 years, 8 months ago (2017-04-14 14:15:41 UTC) #22
brettw
3 years, 8 months ago (2017-04-14 16:36:01 UTC) #23
Message was sent while issue was closed.
Sorry, my understanding of the Python style was not very good.

Powered by Google App Engine
This is Rietveld 408576698