Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2819813002: Translate: remove --disable-translate flag (Closed)

Created:
3 years, 8 months ago by Takashi Toyoshima
Modified:
3 years, 8 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Translate: remove --disable-translate flag Today, the flag is not maintained well, and is not consistently checked to invoke the translation feature. For testing, the translate feature is automatically disabled when the API Key is not used to compile chromium. This check is also rough, but should work similarly. See, https://codereview.chromium.org/1185703007 To disable the feature completely, PolicyList can overwrite the translate setting. This should work as users disable the feature in chrome://settings. See, https://www.chromium.org/administrators/policy-list-3#TranslateEnabled BUG=n/a Review-Url: https://codereview.chromium.org/2819813002 Cr-Commit-Position: refs/heads/master@{#466605} Committed: https://chromium.googlesource.com/chromium/src/+/4baa4206fac22a91b3c76a429143fc061017f318

Patch Set 1 #

Total comments: 1

Patch Set 2 : Merge branch 'master' into translate_remove_disable_flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -57 lines) Patch
M components/translate/core/browser/translate_browser_metrics.h View 1 chunk +1 line, -1 line 0 comments Download
M components/translate/core/browser/translate_browser_metrics_unittest.cc View 3 chunks +12 lines, -20 lines 0 comments Download
M components/translate/core/browser/translate_download_manager.h View 1 1 chunk +2 lines, -5 lines 0 comments Download
M components/translate/core/browser/translate_download_manager.cc View 1 2 chunks +6 lines, -16 lines 0 comments Download
M components/translate/core/browser/translate_manager.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download
M components/translate/core/common/translate_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/translate/core/common/translate_switches.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Takashi Toyoshima
Hi groby, On creating another patch to remove the alpha language support, I notice that ...
3 years, 8 months ago (2017-04-14 11:34:39 UTC) #5
groby-ooo-7-16
On 2017/04/14 11:34:39, Takashi Toyoshima wrote: > Hi groby, > > On creating another patch ...
3 years, 8 months ago (2017-04-20 19:38:40 UTC) #8
Takashi Toyoshima
n/p. this isn't urgent at all :) just a small cleanup that another code review ...
3 years, 8 months ago (2017-04-21 02:44:43 UTC) #9
groby-ooo-7-16
lgtm
3 years, 8 months ago (2017-04-21 19:07:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819813002/20001
3 years, 8 months ago (2017-04-24 08:32:09 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 09:14:25 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4baa4206fac22a91b3c76a429143...

Powered by Google App Engine
This is Rietveld 408576698