Translate: remove --disable-translate flag

Translate: remove --disable-translate flag

Today, the flag is not maintained well, and is not consistently checked
to invoke the translation feature.

For testing, the translate feature is automatically disabled when
the API Key is not used to compile chromium. This check is also rough,
but should work similarly.
See, https://codereview.chromium.org/1185703007

To disable the feature completely, PolicyList can overwrite the translate
setting. This should work as users disable the feature in chrome://settings.
See, https://www.chromium.org/administrators/policy-list-3#TranslateEnabled

BUG=n/a

Review-Url: https://codereview.chromium.org/2819813002
Cr-Commit-Position: refs/heads/master@{#466605}
Committed: https://chromium.googlesource.com/chromium/src/+/4baa4206fac22a91b3c76a429143fc061017f318

[Takashi Toyoshima, 2017-04-14 11:30:23]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 11:30:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Takashi Toyoshima, 2017-04-14 11:32:42]

Description was changed from

==========
Translate: remove --disable-translate flag

Today, the flag is not maintained well, and is not consistently checked
to invoke the translation feature.

For testing, the translate feature is automatically disabled when
the API Key is not used to compile chromium. This check is also rough,
but should work similarly.
See, https://codereview.chromium.org/1185703007

To disable the feature completely, PolicyList can overwrite the translate
setting. This should work as users disable the feature in chrome://settings.
See, https://www.chromium.org/administrators/policy-list-3#TranslateEnabled

BUG=n/a
==========

to

==========
Translate: remove --disable-translate flag

Today, the flag is not maintained well, and is not consistently checked
to invoke the translation feature.

For testing, the translate feature is automatically disabled when
the API Key is not used to compile chromium. This check is also rough,
but should work similarly.
See, https://codereview.chromium.org/1185703007

To disable the feature completely, PolicyList can overwrite the translate
setting. This should work as users disable the feature in chrome://settings.
See, https://www.chromium.org/administrators/policy-list-3#TranslateEnabled

BUG=n/a
==========

[Takashi Toyoshima, 2017-04-14 11:32:43]

toyoshim@chromium.org changed reviewers:
+ groby@chromium.org

[Takashi Toyoshima, 2017-04-14 11:34:39]

Hi groby,

On creating another patch to remove the alpha language support, I notice that we
have many disabler, but some of them are not maintained well.

What do you think about removing the switch?

[commit-bot: I haz the power, 2017-04-14 12:14:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 12:14:29]

Dry run: This issue passed the CQ dry run.

[groby-ooo-7-16, 2017-04-20 19:38:40]

On 2017/04/14 11:34:39, Takashi Toyoshima wrote:
> Hi groby,
> 
> On creating another patch to remove the alpha language support, I notice that
we
> have many disabler, but some of them are not maintained well.
> 
> What do you think about removing the switch?

Apologies for missing this. When we remove the switch, how will that affect
ChromePublic.apk? Will the bug (#500025) still be addressed?

[Takashi Toyoshima, 2017-04-21 02:44:43]

n/p. this isn't urgent at all :)
just a small cleanup that another code review reminds me.

https://codereview.chromium.org/2819813002/diff/1/components/translate/core/b...
File components/translate/core/browser/translate_manager.cc (right):

https://codereview.chromium.org/2819813002/diff/1/components/translate/core/b...
components/translate/core/browser/translate_manager.cc:170:
!::google_apis::HasKeysConfigured()) {
Yes, this check was added to fix the issue 500025, and still works.

[groby-ooo-7-16, 2017-04-21 19:07:35]

lgtm

[Takashi Toyoshima, 2017-04-24 08:31:46]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2017-04-24 08:31:46]

The patchset sent to the CQ was uploaded after l-g-t-m from groby@chromium.org
Link to the patchset: https://codereview.chromium.org/2819813002/#ps20001
(title: "Merge branch 'master' into translate_remove_disable_flag")

[commit-bot: I haz the power, 2017-04-24 08:32:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 09:14:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493022706125390,
"parent_rev": "d5521d9d44f51d4372ac4246747761c437739e9d", "commit_rev":
"4baa4206fac22a91b3c76a429143fc061017f318"}

[commit-bot: I haz the power, 2017-04-24 09:14:24]

Description was changed from

==========
Translate: remove --disable-translate flag

Today, the flag is not maintained well, and is not consistently checked
to invoke the translation feature.

For testing, the translate feature is automatically disabled when
the API Key is not used to compile chromium. This check is also rough,
but should work similarly.
See, https://codereview.chromium.org/1185703007

To disable the feature completely, PolicyList can overwrite the translate
setting. This should work as users disable the feature in chrome://settings.
See, https://www.chromium.org/administrators/policy-list-3#TranslateEnabled

BUG=n/a
==========

to

==========
Translate: remove --disable-translate flag

Today, the flag is not maintained well, and is not consistently checked
to invoke the translation feature.

For testing, the translate feature is automatically disabled when
the API Key is not used to compile chromium. This check is also rough,
but should work similarly.
See, https://codereview.chromium.org/1185703007

To disable the feature completely, PolicyList can overwrite the translate
setting. This should work as users disable the feature in chrome://settings.
See, https://www.chromium.org/administrators/policy-list-3#TranslateEnabled

BUG=n/a

Review-Url: https://codereview.chromium.org/2819813002
Cr-Commit-Position: refs/heads/master@{#466605}
Committed:
https://chromium.googlesource.com/chromium/src/+/4baa4206fac22a91b3c76a429143...
==========

[commit-bot: I haz the power, 2017-04-24 09:14:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4baa4206fac22a91b3c76a429143...