Reorganize GUIDs for GPU memory buffers

Reorganize GUIDs for GPU memory buffers

This CL replaces current GUID generators (GetGenericSharedMemoryGUID-
-ForTracing and GetGpuMemoryBufferGUIDForTracing) with new GUID
generators GetSharedMemoryGUIDForTracing and GetGenericSharedGpumemory-
-GUIDForTracing. The formater is used for GPU memory buffer that use
base::SharedMemory, and the latter is not. This fix is required to know
shared memory usages on memory-infra accurately.

BUG=604726
TEST=n/a
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2819803002
Cr-Commit-Position: refs/heads/master@{#465529}
Committed: https://chromium.googlesource.com/chromium/src/+/7c6261c7a497796269a6befd9efd7dfca9957fe8

[hajimehoshi, 2017-04-14 11:11:25]

Description was changed from

==========
Reorganize GUIDs for GPU memory buffers

This CL replaces current GUID generators (GetGenericSharedMemoryGUID-
-ForTracing and GetGpuMemoryBufferGUIDForTracing) with new GUID
generators GetSharedMemoryGUIDForTracing and GetGenericSharedGpumemory-
-GUIDForTracing. The formater is used for GPU memory buffer that use
base::SharedMemory, and the latter is not. This fix is required to know
shared memory usages on memory-infra accurately.

BUG=604726
TEST=n/a
==========

to

==========
Reorganize GUIDs for GPU memory buffers

This CL replaces current GUID generators (GetGenericSharedMemoryGUID-
-ForTracing and GetGpuMemoryBufferGUIDForTracing) with new GUID
generators GetSharedMemoryGUIDForTracing and GetGenericSharedGpumemory-
-GUIDForTracing. The formater is used for GPU memory buffer that use
base::SharedMemory, and the latter is not. This fix is required to know
shared memory usages on memory-infra accurately.

BUG=604726
TEST=n/a
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[hajimehoshi, 2017-04-14 11:12:23]

Description was changed from

==========
Reorganize GUIDs for GPU memory buffers

This CL replaces current GUID generators (GetGenericSharedMemoryGUID-
-ForTracing and GetGpuMemoryBufferGUIDForTracing) with new GUID
generators GetSharedMemoryGUIDForTracing and GetGenericSharedGpumemory-
-GUIDForTracing. The formater is used for GPU memory buffer that use
base::SharedMemory, and the latter is not. This fix is required to know
shared memory usages on memory-infra accurately.

BUG=604726
TEST=n/a
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Reorganize GUIDs for GPU memory buffers

This CL replaces current GUID generators (GetGenericSharedMemoryGUID-
-ForTracing and GetGpuMemoryBufferGUIDForTracing) with new GUID
generators GetSharedMemoryGUIDForTracing and GetGenericSharedGpumemory-
-GUIDForTracing. The formater is used for GPU memory buffer that use
base::SharedMemory, and the latter is not. This fix is required to know
shared memory usages on memory-infra accurately.

BUG=604726
TEST=n/a
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[hajimehoshi, 2017-04-14 11:12:23]

hajimehoshi@chromium.org changed reviewers:
+ ericrk@chromium.org

[hajimehoshi, 2017-04-14 11:13:04]

hajimehoshi@chromium.org changed reviewers:
+ reveman@chromium.org

[hajimehoshi, 2017-04-14 11:17:10]

hajimehoshi@chromium.org changed reviewers:
+ danakj@chromium.org

[hajimehoshi, 2017-04-14 11:18:35]

hajimehoshi@chromium.org changed reviewers:
+ jbauman@chromium.org
- danakj@chromium.org

[hajimehoshi, 2017-04-14 11:21:39]

hajimehoshi@chromium.org changed reviewers:
+ danakj@chromium.org

[hajimehoshi, 2017-04-14 11:24:21]

hajimehoshi@chromium.org changed reviewers:
+ dalecurtis@google.com

[hajimehoshi, 2017-04-14 11:25:10]

hajimehoshi@chromium.org changed reviewers:
+ dalecurtis@chromium.org
- dalecurtis@google.com

[hajimehoshi, 2017-04-14 11:25:20]

PTAL

[hajimehoshi, 2017-04-14 11:26:01]

The CQ bit was checked by hajimehoshi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 11:26:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 12:58:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 12:58:30]

Dry run: This issue passed the CQ dry run.

[DaleCurtis, 2017-04-14 18:27:32]

lgtm % q.

https://codereview.chromium.org/2819803002/diff/1/media/video/gpu_memory_buff...
File media/video/gpu_memory_buffer_video_frame_pool.cc (right):

https://codereview.chromium.org/2819803002/diff/1/media/video/gpu_memory_buff...
media/video/gpu_memory_buffer_video_frame_pool.cc:475: const auto&
shared_buffer_guid =
is const& really what you want here?

[ericrk, 2017-04-14 19:49:40]

One comment, but otherwise LGTM, thanks for the refactor!

https://codereview.chromium.org/2819803002/diff/1/cc/raster/staging_buffer_po...
File cc/raster/staging_buffer_pool.cc (right):

https://codereview.chromium.org/2819803002/diff/1/cc/raster/staging_buffer_po...
cc/raster/staging_buffer_pool.cc:118: if (gpu_memory_buffer->GetHandle().type ==
gfx::SHARED_MEMORY_BUFFER) {
Why not use GetGUIDForTracing in this case?

[jbauman, 2017-04-14 22:10:30]

lgtm

[hajimehoshi, 2017-04-17 06:17:17]

The CQ bit was checked by hajimehoshi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 06:17:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hajimehoshi, 2017-04-17 06:18:07]

Thank you!

https://codereview.chromium.org/2819803002/diff/1/cc/raster/staging_buffer_po...
File cc/raster/staging_buffer_pool.cc (right):

https://codereview.chromium.org/2819803002/diff/1/cc/raster/staging_buffer_po...
cc/raster/staging_buffer_pool.cc:118: if (gpu_memory_buffer->GetHandle().type ==
gfx::SHARED_MEMORY_BUFFER) {
On 2017/04/14 19:49:39, ericrk wrote:
> Why not use GetGUIDForTracing in this case?

Oops, I forgot to do this. Done.

https://codereview.chromium.org/2819803002/diff/1/media/video/gpu_memory_buff...
File media/video/gpu_memory_buffer_video_frame_pool.cc (right):

https://codereview.chromium.org/2819803002/diff/1/media/video/gpu_memory_buff...
media/video/gpu_memory_buffer_video_frame_pool.cc:475: const auto&
shared_buffer_guid =
On 2017/04/14 18:27:32, DaleCurtis wrote:
> is const& really what you want here?

Actually not. Done.

[hajimehoshi, 2017-04-17 06:19:46]

hajimehoshi@chromium.org changed reviewers:
+ msw@chromium.org

[hajimehoshi, 2017-04-17 06:20:08]

+msw for ui/gfx/*
PTAL

[commit-bot: I haz the power, 2017-04-17 08:13:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 08:13:33]

Dry run: This issue passed the CQ dry run.

[reveman, 2017-04-17 13:21:06]

https://codereview.chromium.org/2819803002/diff/20001/cc/raster/staging_buffe...
File cc/raster/staging_buffer_pool.cc (right):

https://codereview.chromium.org/2819803002/diff/20001/cc/raster/staging_buffe...
cc/raster/staging_buffer_pool.cc:118:
gpu_memory_buffer->GetHandle().GetGUIDForTracing(tracing_process_id);
We shouldn't be using the handle for non-IPC things. Can you get the tracing id
from the buffer instead?

https://codereview.chromium.org/2819803002/diff/20001/cc/resources/resource_p...
File cc/resources/resource_provider.cc (right):

https://codereview.chromium.org/2819803002/diff/20001/cc/resources/resource_p...
cc/resources/resource_provider.cc:2180: guid =
resource.gpu_memory_buffer->GetHandle().GetGUIDForTracing(
ditto

https://codereview.chromium.org/2819803002/diff/20001/media/video/gpu_memory_...
File media/video/gpu_memory_buffer_video_frame_pool.cc (right):

https://codereview.chromium.org/2819803002/diff/20001/media/video/gpu_memory_...
media/video/gpu_memory_buffer_video_frame_pool.cc:476:
plane_resource.gpu_memory_buffer->GetHandle().GetGUIDForTracing(
ditto

https://codereview.chromium.org/2819803002/diff/20001/ui/gfx/gpu_memory_buffe...
File ui/gfx/gpu_memory_buffer.cc (right):

https://codereview.chromium.org/2819803002/diff/20001/ui/gfx/gpu_memory_buffe...
ui/gfx/gpu_memory_buffer.cc:56: if (type == gfx::SHARED_MEMORY_BUFFER)
not a fan of this special case but should go away if we move GetGUIDForTracing
to the GpuMemoryBuffer API

https://codereview.chromium.org/2819803002/diff/20001/ui/gfx/gpu_memory_buffer.h
File ui/gfx/gpu_memory_buffer.h (right):

https://codereview.chromium.org/2819803002/diff/20001/ui/gfx/gpu_memory_buffe...
ui/gfx/gpu_memory_buffer.h:58: uint64_t tracing_process_id);
I don't think this belongs as part of the Handle. The handle should only be used
for IPC. Can we add this to the GpuMemoryBuffer API instead?

[ericrk, 2017-04-17 18:10:15]

https://codereview.chromium.org/2819803002/diff/20001/ui/gfx/gpu_memory_buffe...
File ui/gfx/gpu_memory_buffer.cc (right):

https://codereview.chromium.org/2819803002/diff/20001/ui/gfx/gpu_memory_buffe...
ui/gfx/gpu_memory_buffer.cc:56: if (type == gfx::SHARED_MEMORY_BUFFER)
On 2017/04/17 13:21:06, reveman wrote:
> not a fan of this special case but should go away if we move GetGUIDForTracing
> to the GpuMemoryBuffer API

This special case was added to allow all shared memory allocations use the same
GUID system (whether or not they were GMBs)... This will allow a global shared
memory tracker to alias dumps with shared memory GMBs. My understanding is that
the GetSharedMemoryGUIDForTracing will eventually be replaced with something
that uses shared memory specific data rather than GMB IDs (this is just an
intermediate step).

Maybe we could avoid this, but it seems like it may be more complex? Maybe a
multi-tiered thing (alias GMBs together, then alias shared memory to the GMB in
an extra step in the browser GMB manager?). But I believe this multi-layered
aliasing is currently broken in memory-infra (GPU uses it though, so it will be
fixed eventually).

Let me know if this makes sense.

I agree that this logic probably shouldn't go on the handle though.

[hajimehoshi, 2017-04-18 08:21:24]

Description was changed from

==========
Reorganize GUIDs for GPU memory buffers

This CL replaces current GUID generators (GetGenericSharedMemoryGUID-
-ForTracing and GetGpuMemoryBufferGUIDForTracing) with new GUID
generators GetSharedMemoryGUIDForTracing and GetGenericSharedGpumemory-
-GUIDForTracing. The formater is used for GPU memory buffer that use
base::SharedMemory, and the latter is not. This fix is required to know
shared memory usages on memory-infra accurately.

BUG=604726
TEST=n/a
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Reorganize GUIDs for GPU memory buffers

This CL replaces current GUID generators (GetGenericSharedMemoryGUID-
-ForTracing and GetGpuMemoryBufferGUIDForTracing) with new GUID
generators GetSharedMemoryGUIDForTracing and GetGenericSharedGpumemory-
-GUIDForTracing. The formater is used for GPU memory buffer that use
base::SharedMemory, and the latter is not. This fix is required to know
shared memory usages on memory-infra accurately.

BUG=604726
TEST=n/a
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[hajimehoshi, 2017-04-18 08:21:59]

Thank you!

https://codereview.chromium.org/2819803002/diff/20001/cc/raster/staging_buffe...
File cc/raster/staging_buffer_pool.cc (right):

https://codereview.chromium.org/2819803002/diff/20001/cc/raster/staging_buffe...
cc/raster/staging_buffer_pool.cc:118:
gpu_memory_buffer->GetHandle().GetGUIDForTracing(tracing_process_id);
On 2017/04/17 13:21:06, reveman wrote:
> We shouldn't be using the handle for non-IPC things. Can you get the tracing
id
> from the buffer instead?

Done.

https://codereview.chromium.org/2819803002/diff/20001/cc/resources/resource_p...
File cc/resources/resource_provider.cc (right):

https://codereview.chromium.org/2819803002/diff/20001/cc/resources/resource_p...
cc/resources/resource_provider.cc:2180: guid =
resource.gpu_memory_buffer->GetHandle().GetGUIDForTracing(
On 2017/04/17 13:21:06, reveman wrote:
> ditto

Done.

https://codereview.chromium.org/2819803002/diff/20001/media/video/gpu_memory_...
File media/video/gpu_memory_buffer_video_frame_pool.cc (right):

https://codereview.chromium.org/2819803002/diff/20001/media/video/gpu_memory_...
media/video/gpu_memory_buffer_video_frame_pool.cc:476:
plane_resource.gpu_memory_buffer->GetHandle().GetGUIDForTracing(
On 2017/04/17 13:21:06, reveman wrote:
> ditto

Done.

https://codereview.chromium.org/2819803002/diff/20001/ui/gfx/gpu_memory_buffe...
File ui/gfx/gpu_memory_buffer.cc (right):

https://codereview.chromium.org/2819803002/diff/20001/ui/gfx/gpu_memory_buffe...
ui/gfx/gpu_memory_buffer.cc:56: if (type == gfx::SHARED_MEMORY_BUFFER)
Done.

On 2017/04/17 18:10:15, ericrk wrote:
> On 2017/04/17 13:21:06, reveman wrote:
> > not a fan of this special case but should go away if we move
GetGUIDForTracing
> > to the GpuMemoryBuffer API
> 
> This special case was added to allow all shared memory allocations use the
same
> GUID system (whether or not they were GMBs)... This will allow a global shared
> memory tracker to alias dumps with shared memory GMBs. My understanding is
that
> the GetSharedMemoryGUIDForTracing will eventually be replaced with something
> that uses shared memory specific data rather than GMB IDs (this is just an
> intermediate step).
> 
> Maybe we could avoid this, but it seems like it may be more complex? Maybe a
> multi-tiered thing (alias GMBs together, then alias shared memory to the GMB
in
> an extra step in the browser GMB manager?). But I believe this multi-layered
> aliasing is currently broken in memory-infra (GPU uses it though, so it will
be
> fixed eventually).
> 
> Let me know if this makes sense.
> 
> I agree that this logic probably shouldn't go on the handle though.

IIUC, when the type is SHARED_MEMORY_BUFFER, the class must be
GpuMemoryBufferImplHandle. The exceptions are subclasses of GpuMemoryBuffer in
tests, but I don't think we need to care them. Thus, defining a virtual function
GetGUIDForTracing to GpuMemoryBuffer and overriding this on
GpuMemoryBufferImplSharedMemory would work.

Right, this is an intermediate step and next I'd need to replace all usages of
GetSharedMemoryGUIDForTracing with one of shared memory tracker.

https://codereview.chromium.org/2819803002/diff/20001/ui/gfx/gpu_memory_buffer.h
File ui/gfx/gpu_memory_buffer.h (right):

https://codereview.chromium.org/2819803002/diff/20001/ui/gfx/gpu_memory_buffe...
ui/gfx/gpu_memory_buffer.h:58: uint64_t tracing_process_id);
On 2017/04/17 13:21:06, reveman wrote:
> I don't think this belongs as part of the Handle. The handle should only be
used
> for IPC. Can we add this to the GpuMemoryBuffer API instead?

Done.

[hajimehoshi, 2017-04-18 08:22:03]

The CQ bit was checked by hajimehoshi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 08:22:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 10:15:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 10:15:44]

Dry run: This issue passed the CQ dry run.

[reveman, 2017-04-18 13:44:53]

thanks for explaining. long term plan sounds good. lgtm + nits

https://codereview.chromium.org/2819803002/diff/40001/ui/gfx/gpu_memory_buffe...
File ui/gfx/gpu_memory_buffer.cc (right):

https://codereview.chromium.org/2819803002/diff/40001/ui/gfx/gpu_memory_buffe...
ui/gfx/gpu_memory_buffer.cc:55: auto handle = GetHandle();
nit: please use GetId() instead. The handle is meant for IPC only.

https://codereview.chromium.org/2819803002/diff/40001/ui/gfx/gpu_memory_buffer.h
File ui/gfx/gpu_memory_buffer.h (right):

https://codereview.chromium.org/2819803002/diff/40001/ui/gfx/gpu_memory_buffe...
ui/gfx/gpu_memory_buffer.h:102: // Returns the GUID for tracing.
nit: please add a TODO and a link to a bug as you explained that this is a
temporary solution.

[danakj, 2017-04-18 13:50:36]

ui/gfx/generic_shared_memory_id.* lgtm

[msw, 2017-04-18 17:12:00]

Looks like danakj@ and reveman@ cover your ui/gfx/OWNERS needs.
(thanks for reviewing, I do not know those memory files well at all)

[Primiano Tucci (use gerrit), 2017-04-18 19:46:17]

On 2017/04/18 17:12:00, msw wrote:
> Looks like danakj@ and reveman@ cover your ui/gfx/OWNERS needs.
> (thanks for reviewing, I do not know those memory files well at all)

Only a drive-by question: does it work it on all platforms? 
IIRC there were some issues (as in, not yet implemented) on OSX and/or Windows
with the shared memory handles IDs. Are they solved?
If not, isn't this going  to break memory reporting on those platforms? (that
would be really undesirable)
If yes, ignore my comment instead :)

[hajimehoshi, 2017-04-19 05:39:05]

On 2017/04/18 19:46:17, Primiano Tucci wrote:
> On 2017/04/18 17:12:00, msw wrote:
> > Looks like danakj@ and reveman@ cover your ui/gfx/OWNERS needs.
> > (thanks for reviewing, I do not know those memory files well at all)
> 
> Only a drive-by question: does it work it on all platforms? 
> IIRC there were some issues (as in, not yet implemented) on OSX and/or Windows
> with the shared memory handles IDs. Are they solved?
> If not, isn't this going  to break memory reporting on those platforms? (that
> would be really undesirable)
> If yes, ignore my comment instead :)

Yes. This CL doesn't have anything to do with SharedMemoryTracker, and just
changes the current GUID generators with new ones, which use buffer ids the same
way.

[hajimehoshi, 2017-04-19 06:15:12]

Thank you!

https://codereview.chromium.org/2819803002/diff/40001/ui/gfx/gpu_memory_buffe...
File ui/gfx/gpu_memory_buffer.cc (right):

https://codereview.chromium.org/2819803002/diff/40001/ui/gfx/gpu_memory_buffe...
ui/gfx/gpu_memory_buffer.cc:55: auto handle = GetHandle();
On 2017/04/18 13:44:52, reveman wrote:
> nit: please use GetId() instead. The handle is meant for IPC only.

Done.

https://codereview.chromium.org/2819803002/diff/40001/ui/gfx/gpu_memory_buffer.h
File ui/gfx/gpu_memory_buffer.h (right):

https://codereview.chromium.org/2819803002/diff/40001/ui/gfx/gpu_memory_buffe...
ui/gfx/gpu_memory_buffer.h:102: // Returns the GUID for tracing.
On 2017/04/18 13:44:53, reveman wrote:
> nit: please add a TODO and a link to a bug as you explained that this is a
> temporary solution.

What is temporary is implementation of GetSharedMemoryGUIDForTracing, which will
be replaced with SharedMemoryTracker's. I've already commented in
GetSharedMemoryGUIDForTracing.

[hajimehoshi, 2017-04-19 06:16:07]

The CQ bit was checked by hajimehoshi@chromium.org

[hajimehoshi, 2017-04-19 06:16:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org, jbauman@chromium.org, ericrk@chromium.org,
reveman@chromium.org, danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2819803002/#ps60001
(title: "Address on reviews")

[commit-bot: I haz the power, 2017-04-19 06:16:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Primiano Tucci (use gerrit), 2017-04-19 08:07:26]

On 2017/04/19 05:39:05, hajimehoshi wrote:
> On 2017/04/18 19:46:17, Primiano Tucci wrote:
> > On 2017/04/18 17:12:00, msw wrote:
> > > Looks like danakj@ and reveman@ cover your ui/gfx/OWNERS needs.
> > > (thanks for reviewing, I do not know those memory files well at all)
> > 
> > Only a drive-by question: does it work it on all platforms? 
> > IIRC there were some issues (as in, not yet implemented) on OSX and/or
Windows
> > with the shared memory handles IDs. Are they solved?
> > If not, isn't this going  to break memory reporting on those platforms?
(that
> > would be really undesirable)
> > If yes, ignore my comment instead :)
> 
> Yes. This CL doesn't have anything to do with SharedMemoryTracker, and just
> changes the current GUID generators with new ones, which use buffer ids the
same
> way.

Ahh right. Sorry I though you were already wiring up the SMT. By looking again,
yeah, this is just a refactoring of the existing code.
As I preemptively said, ignore my comment

[commit-bot: I haz the power, 2017-04-19 08:16:56]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492582567500750,
"parent_rev": "896daeca6982c6250e36660df8f957fbb01437b0", "commit_rev":
"7c6261c7a497796269a6befd9efd7dfca9957fe8"}

[commit-bot: I haz the power, 2017-04-19 08:17:05]

Description was changed from

==========
Reorganize GUIDs for GPU memory buffers

This CL replaces current GUID generators (GetGenericSharedMemoryGUID-
-ForTracing and GetGpuMemoryBufferGUIDForTracing) with new GUID
generators GetSharedMemoryGUIDForTracing and GetGenericSharedGpumemory-
-GUIDForTracing. The formater is used for GPU memory buffer that use
base::SharedMemory, and the latter is not. This fix is required to know
shared memory usages on memory-infra accurately.

BUG=604726
TEST=n/a
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Reorganize GUIDs for GPU memory buffers

This CL replaces current GUID generators (GetGenericSharedMemoryGUID-
-ForTracing and GetGpuMemoryBufferGUIDForTracing) with new GUID
generators GetSharedMemoryGUIDForTracing and GetGenericSharedGpumemory-
-GUIDForTracing. The formater is used for GPU memory buffer that use
base::SharedMemory, and the latter is not. This fix is required to know
shared memory usages on memory-infra accurately.

BUG=604726
TEST=n/a
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2819803002
Cr-Commit-Position: refs/heads/master@{#465529}
Committed:
https://chromium.googlesource.com/chromium/src/+/7c6261c7a497796269a6befd9efd...
==========

[commit-bot: I haz the power, 2017-04-19 08:17:06]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/7c6261c7a497796269a6befd9efd...