Reorganize GUIDs for GPU memory buffers

media/video/gpu_memory_buffer_video_frame_pool.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/video/gpu_memory_buffer_video_frame_pool.h"
 
 #include <GLES2/gl2.h>
 #include <GLES2/gl2ext.h>
 #include <stddef.h>
 #include <stdint.h>
@@ skipping 454 matching lines @@
         base::trace_event::MemoryAllocatorDump* dump =
             pmd->CreateAllocatorDump(dump_name);
         size_t buffer_size_in_bytes = gfx::BufferSizeForBufferFormat(
             plane_resource.size, plane_resource.gpu_memory_buffer->GetFormat());
         dump->AddScalar(base::trace_event::MemoryAllocatorDump::kNameSize,
                         base::trace_event::MemoryAllocatorDump::kUnitsBytes,
                         buffer_size_in_bytes);
         dump->AddScalar("free_size",
                         base::trace_event::MemoryAllocatorDump::kUnitsBytes,
                         frame_resources->IsInUse() ? 0 : buffer_size_in_bytes);
-        base::trace_event::MemoryAllocatorDumpGuid shared_buffer_guid =
-            gfx::GetGpuMemoryBufferGUIDForTracing(tracing_process_id,
-                                                  buffer_id);
+        const auto& shared_buffer_guid =

[DaleCurtis, 2017/04/14 18:27:32]

is const& really what you want here?

[hajimehoshi, 2017/04/17 06:18:07]

Actually not. Done.

+            plane_resource.gpu_memory_buffer->GetHandle().GetGUIDForTracing(
+                tracing_process_id);
         pmd->CreateSharedGlobalAllocatorDump(shared_buffer_guid);
         pmd->AddOwnershipEdge(dump->guid(), shared_buffer_guid, kImportance);
       }
     }
   }
   return true;
 }
 
 void GpuMemoryBufferVideoFramePool::PoolImpl::OnCopiesDone(
     const scoped_refptr<VideoFrame>& video_frame,
@@ skipping 338 matching lines @@
 }
 
 void GpuMemoryBufferVideoFramePool::MaybeCreateHardwareFrame(
     const scoped_refptr<VideoFrame>& video_frame,
     const FrameReadyCB& frame_ready_cb) {
   DCHECK(video_frame);
   pool_impl_->CreateHardwareFrame(video_frame, frame_ready_cb);
 }
 
 }  // namespace media