Translate: do not show the context menu entry when the feature is disabled

Translate: do not show the context menu entry when the feature is disabled

Currently, Chrome has a context menu entry to translate the page
even when the translate feature is disabled by PolicyList.
But, it should be better to stop adding the entry when the feature
is disabled.

BUG=711217
TBR=sky@chromium.org, michaeldo@chromium.org

Review-Url: https://codereview.chromium.org/2819793002
Cr-Commit-Position: refs/heads/master@{#465177}
Committed: https://chromium.googlesource.com/chromium/src/+/c64ccfd0e457a5b54ac57ed095064b0f0bd59203

[Takashi Toyoshima, 2017-04-14 10:14:13]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 10:14:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Takashi Toyoshima, 2017-04-14 10:18:12]

Description was changed from

==========
Translate: do not show the context menu entry when the feature is disabled

Currently, Chrome has a context menu entry to translate the page
even though the translate feature is disabled by PolicyList.
But, it should be better to stop adding the entry when the feature
is disabled.

BUG=711217
==========

to

==========
Translate: do not show the context menu entry when the feature is disabled

Currently, Chrome has a context menu entry to translate the page
even though the translate feature is disabled by PolicyList.
But, it should be better to stop adding the entry when the feature
is disabled.

BUG=711217
==========

[Takashi Toyoshima, 2017-04-14 10:18:12]

toyoshim@chromium.org changed reviewers:
+ droger@chromium.org

[Takashi Toyoshima, 2017-04-14 10:18:43]

Description was changed from

==========
Translate: do not show the context menu entry when the feature is disabled

Currently, Chrome has a context menu entry to translate the page
even though the translate feature is disabled by PolicyList.
But, it should be better to stop adding the entry when the feature
is disabled.

BUG=711217
==========

to

==========
Translate: do not show the context menu entry when the feature is disabled

Currently, Chrome has a context menu entry to translate the page
even when the translate feature is disabled by PolicyList.
But, it should be better to stop adding the entry when the feature
is disabled.

BUG=711217
==========

[Takashi Toyoshima, 2017-04-14 10:22:28]

Can you take a look?

https://codereview.chromium.org/2819793002/diff/20001/chrome/browser/renderer...
File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right):

https://codereview.chromium.org/2819793002/diff/20001/chrome/browser/renderer...
chrome/browser/renderer_context_menu/render_view_context_menu.cc:1248: if
(prefs->IsEnabled()) {
This is the main change. Others are just a mechanical for file moving.

https://codereview.chromium.org/2819793002/diff/20001/components/translate/co...
File components/translate/core/browser/translate_pref_names.h (left):

https://codereview.chromium.org/2819793002/diff/20001/components/translate/co...
components/translate/core/browser/translate_pref_names.h:1: // Copyright 2014
The Chromium Authors. All rights reserved.
Is this fine to move this file from common to browser?
There are no renderer users now.

[droger, 2017-04-14 11:45:28]

lgtm

https://codereview.chromium.org/2819793002/diff/20001/components/translate/co...
File components/translate/core/browser/translate_pref_names.h (left):

https://codereview.chromium.org/2819793002/diff/20001/components/translate/co...
components/translate/core/browser/translate_pref_names.h:1: // Copyright 2014
The Chromium Authors. All rights reserved.
On 2017/04/14 10:22:28, Takashi Toyoshima wrote:
> Is this fine to move this file from common to browser?
> There are no renderer users now.

Sure!

[Takashi Toyoshima, 2017-04-17 05:17:54]

toyoshim@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Takashi Toyoshima, 2017-04-17 05:18:16]

Description was changed from

==========
Translate: do not show the context menu entry when the feature is disabled

Currently, Chrome has a context menu entry to translate the page
even when the translate feature is disabled by PolicyList.
But, it should be better to stop adding the entry when the feature
is disabled.

BUG=711217
==========

to

==========
Translate: do not show the context menu entry when the feature is disabled

Currently, Chrome has a context menu entry to translate the page
even when the translate feature is disabled by PolicyList.
But, it should be better to stop adding the entry when the feature
is disabled.

BUG=711217
TBR=sky@chromium.org
==========

[Takashi Toyoshima, 2017-04-17 05:18:56]

+lazyboy for chrome/browser/renderer_context_menu/render_view_context_menu.cc
TBR=sky for other chrome files

[lazyboy, 2017-04-17 20:25:45]

render_view_context_menu.cc lgtm.

https://codereview.chromium.org/2819793002/diff/20001/chrome/browser/renderer...
File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right):

https://codereview.chromium.org/2819793002/diff/20001/chrome/browser/renderer...
chrome/browser/renderer_context_menu/render_view_context_menu.cc:1248: if
(prefs->IsEnabled()) {
On 2017/04/14 10:22:28, Takashi Toyoshima wrote:
> This is the main change. Others are just a mechanical for file moving.

Thanks for pointing this one out.

[Takashi Toyoshima, 2017-04-18 03:31:09]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2017-04-18 03:31:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 03:40:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 03:40:13]

Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Takashi Toyoshima, 2017-04-18 06:42:44]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2017-04-18 06:42:45]

The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org,
lazyboy@chromium.org
Link to the patchset: https://codereview.chromium.org/2819793002/#ps60001
(title: "ios BUILD.gn fix")

[commit-bot: I haz the power, 2017-04-18 06:43:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 06:52:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 06:52:42]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Takashi Toyoshima, 2017-04-18 07:18:06]

Description was changed from

==========
Translate: do not show the context menu entry when the feature is disabled

Currently, Chrome has a context menu entry to translate the page
even when the translate feature is disabled by PolicyList.
But, it should be better to stop adding the entry when the feature
is disabled.

BUG=711217
TBR=sky@chromium.org
==========

to

==========
Translate: do not show the context menu entry when the feature is disabled

Currently, Chrome has a context menu entry to translate the page
even when the translate feature is disabled by PolicyList.
But, it should be better to stop adding the entry when the feature
is disabled.

BUG=711217
TBR=sky@chromium.org, michaeldo@chromium.org
==========

[Takashi Toyoshima, 2017-04-18 07:18:49]

+TBR michaeldo for ios/web_view user side mechanical changes.

[Takashi Toyoshima, 2017-04-18 07:18:55]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2017-04-18 07:18:55]

The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org,
lazyboy@chromium.org
Link to the patchset: https://codereview.chromium.org/2819793002/#ps80001
(title: "some more include path changes for ios/android")

[commit-bot: I haz the power, 2017-04-18 07:19:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 08:34:24]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492499935403970,
"parent_rev": "71abad621416fd3cbb69ebb2dae0d90b84be0287", "commit_rev":
"c64ccfd0e457a5b54ac57ed095064b0f0bd59203"}

[commit-bot: I haz the power, 2017-04-18 08:34:34]

Description was changed from

==========
Translate: do not show the context menu entry when the feature is disabled

Currently, Chrome has a context menu entry to translate the page
even when the translate feature is disabled by PolicyList.
But, it should be better to stop adding the entry when the feature
is disabled.

BUG=711217
TBR=sky@chromium.org, michaeldo@chromium.org
==========

to

==========
Translate: do not show the context menu entry when the feature is disabled

Currently, Chrome has a context menu entry to translate the page
even when the translate feature is disabled by PolicyList.
But, it should be better to stop adding the entry when the feature
is disabled.

BUG=711217
TBR=sky@chromium.org, michaeldo@chromium.org

Review-Url: https://codereview.chromium.org/2819793002
Cr-Commit-Position: refs/heads/master@{#465177}
Committed:
https://chromium.googlesource.com/chromium/src/+/c64ccfd0e457a5b54ac57ed09506...
==========

[commit-bot: I haz the power, 2017-04-18 08:34:35]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/c64ccfd0e457a5b54ac57ed09506...