Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu.cc

Issue 2819793002: Translate: do not show the context menu entry when the feature is disabled (Closed)
Patch Set: some more include path changes for ios/android Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_context_menu/render_view_context_menu.cc
diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu.cc b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
index 6bffc3545d4b9286d24a687ae5049eb49b6aaa47..e56a7f0d8a72fec1dcccdec53daef69924354848 100644
--- a/chrome/browser/renderer_context_menu/render_view_context_menu.cc
+++ b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
@@ -1245,14 +1245,16 @@ void RenderViewContextMenu::AppendPageItems() {
std::unique_ptr<translate::TranslatePrefs> prefs(
ChromeTranslateClient::CreateTranslatePrefs(
GetPrefs(browser_context_)));
- std::string locale =
- translate::TranslateManager::GetTargetLanguage(prefs.get());
- base::string16 language =
- l10n_util::GetDisplayNameForLocale(locale, locale, true);
- menu_model_.AddItem(
- IDC_CONTENT_CONTEXT_TRANSLATE,
- l10n_util::GetStringFUTF16(IDS_CONTENT_CONTEXT_TRANSLATE, language));
- AddGoogleIconToLastMenuItem(&menu_model_);
+ if (prefs->IsEnabled()) {
+ std::string locale =
+ translate::TranslateManager::GetTargetLanguage(prefs.get());
+ base::string16 language =
+ l10n_util::GetDisplayNameForLocale(locale, locale, true);
+ menu_model_.AddItem(
+ IDC_CONTENT_CONTEXT_TRANSLATE,
+ l10n_util::GetStringFUTF16(IDS_CONTENT_CONTEXT_TRANSLATE, language));
+ AddGoogleIconToLastMenuItem(&menu_model_);
+ }
}
}

Powered by Google App Engine
This is Rietveld 408576698