Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2819763002: Add end-to-end test for CopylessPaste (Closed)

Created:
3 years, 8 months ago by wychen
Modified:
3 years, 8 months ago
Reviewers:
Maria
CC:
chromium-reviews, agrieve+watch_chromium.org, dproctor
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add end-to-end test for CopylessPaste BUG=693650 Review-Url: https://codereview.chromium.org/2819763002 Cr-Commit-Position: refs/heads/master@{#465456} Committed: https://chromium.googlesource.com/chromium/src/+/12c4f68ae8557ca0af22bbe6281a832e2ed29d9a

Patch Set 1 #

Total comments: 2

Patch Set 2 : split tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -0 lines) Patch
M chrome/android/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/AppIndexingUtil.java View 4 chunks +11 lines, -0 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/CopylessPasteTest.java View 1 1 chunk +184 lines, -0 lines 0 comments Download
A chrome/test/data/android/appindexing/json-ld.html View 1 chunk +11 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (9 generated)
wychen
PTAL
3 years, 8 months ago (2017-04-14 06:45:31 UTC) #5
Maria
lgtm https://codereview.chromium.org/2819763002/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/CopylessPasteTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/CopylessPasteTest.java (right): https://codereview.chromium.org/2819763002/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/CopylessPasteTest.java#newcode101 chrome/android/javatests/src/org/chromium/chrome/browser/CopylessPasteTest.java:101: assertEquals(0, callbackHelper.getCallCount()); Seems like these ought to be ...
3 years, 8 months ago (2017-04-18 00:01:48 UTC) #8
wychen
https://codereview.chromium.org/2819763002/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/CopylessPasteTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/CopylessPasteTest.java (right): https://codereview.chromium.org/2819763002/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/CopylessPasteTest.java#newcode101 chrome/android/javatests/src/org/chromium/chrome/browser/CopylessPasteTest.java:101: assertEquals(0, callbackHelper.getCallCount()); On 2017/04/18 00:01:48, Maria wrote: > Seems ...
3 years, 8 months ago (2017-04-18 22:19:05 UTC) #9
Maria
lgtm
3 years, 8 months ago (2017-04-18 22:59:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819763002/40001
3 years, 8 months ago (2017-04-18 23:18:56 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/12c4f68ae8557ca0af22bbe6281a832e2ed29d9a
3 years, 8 months ago (2017-04-19 01:20:06 UTC) #15
lijeffrey
On 2017/04/19 01:20:06, commit-bot: I haz the power wrote: > Committed patchset #2 (id:40001) as ...
3 years, 8 months ago (2017-04-19 18:23:08 UTC) #16
fhorschig
3 years, 8 months ago (2017-04-21 13:16:11 UTC) #17
Message was sent while issue was closed.
On 2017/04/19 18:23:08, lijeffrey wrote:
> On 2017/04/19 01:20:06, commit-bot: I haz the power wrote:
> > Committed patchset #2 (id:40001) as
> >
>
https://chromium.googlesource.com/chromium/src/+/12c4f68ae8557ca0af22bbe6281a...
> 
> Findit's flake analyzer suggests this CL introduced a flaky test according to
> analysis
>
https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWV...
> 
> Can someone please help confirm?

There are more data points now that strongly support that:
https://crbug.com/713878
(and https://crbug.com/713895)

Assigning wychen@ for now.

> 
> Thanks,
> Jeff on behalf of Findit team

Powered by Google App Engine
This is Rietveld 408576698