Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2826803002: Add UMA for CopylessPaste cache (Closed)

Created:
3 years, 8 months ago by wychen
Modified:
3 years, 8 months ago
Reviewers:
jwd, Maria
CC:
chromium-reviews, asvitkine+watch_chromium.org, agrieve+watch_chromium.org, dproctor
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UMA for CopylessPaste cache BUG=693650 Review-Url: https://codereview.chromium.org/2826803002 Cr-Commit-Position: refs/heads/master@{#465860} Committed: https://chromium.googlesource.com/chromium/src/+/46d05bbdf9e2faec3d4ff1d245e380d6eecce774

Patch Set 1 #

Total comments: 1

Patch Set 2 : comments #

Patch Set 3 : fix junit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/AppIndexingUtil.java View 1 3 chunks +15 lines, -0 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/AppIndexingUtilTest.java View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
wychen
PTAL
3 years, 8 months ago (2017-04-18 22:33:57 UTC) #3
Maria
lgtm
3 years, 8 months ago (2017-04-18 23:01:10 UTC) #4
wychen
jwd@, could you take a look at the histogram? Thanks!
3 years, 8 months ago (2017-04-18 23:17:57 UTC) #6
jwd
LGTM with comment. https://codereview.chromium.org/2826803002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/AppIndexingUtil.java File chrome/android/java/src/org/chromium/chrome/browser/AppIndexingUtil.java (right): https://codereview.chromium.org/2826803002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/AppIndexingUtil.java#newcode36 chrome/android/java/src/org/chromium/chrome/browser/AppIndexingUtil.java:36: // Constants used to log UMA ...
3 years, 8 months ago (2017-04-19 18:49:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826803002/40001
3 years, 8 months ago (2017-04-19 20:59:05 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/275680)
3 years, 8 months ago (2017-04-19 21:49:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826803002/60001
3 years, 8 months ago (2017-04-20 00:51:05 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 02:07:46 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/46d05bbdf9e2faec3d4ff1d245e3...

Powered by Google App Engine
This is Rietveld 408576698