Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2819623002: Revert of A drop-down should take a line to be always aligned with text-fields. (Closed)

Created:
3 years, 8 months ago by sebsg
Modified:
3 years, 8 months ago
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of A drop-down should take a line to be always aligned with text-fields. (patchset #2 id:20001 of https://codereview.chromium.org/2791363002/ ) Reason for revert: The feature for which this CL was made was reverted, and this CL breaks the UI of the credit card editor. Both should be landed together when fixed. Original issue's description: > Align text-fields/drop-down-fields on Payment Request form. > > -- When we click on a text-field, the title text moves, so the best way > to make it permanently aligned is to make all the drop-down fields > take a full line. > > BUG=707860 > > Review-Url: https://codereview.chromium.org/2791363002 > Cr-Commit-Position: refs/heads/master@{#462831} > Committed: https://chromium.googlesource.com/chromium/src/+/4ba9b212af6288fea45140610770a198d0241a58 TBR=mathp@chromium.org,rouslan@chromium.org,parastoog@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=707860 Review-Url: https://codereview.chromium.org/2819623002 Cr-Commit-Position: refs/heads/master@{#464527} Committed: https://chromium.googlesource.com/chromium/src/+/7ca3add13622c453c70565b8a21255133bc39687

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -11 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java View 1 chunk +6 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
sebsg
Created Revert of A drop-down should take a line to be always aligned with text-fields.
3 years, 8 months ago (2017-04-13 19:38:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819623002/1
3 years, 8 months ago (2017-04-13 19:39:02 UTC) #3
please use gerrit instead
lgtm
3 years, 8 months ago (2017-04-13 19:39:07 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 20:28:17 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7ca3add13622c453c70565b8a212...

Powered by Google App Engine
This is Rietveld 408576698