A drop-down should take a line to be always aligned with text-fields.

Align text-fields/drop-down-fields on Payment Request form.

-- When we click on a text-field, the title text moves, so the best way
 to make it permanently aligned is to make all the drop-down fields
 take a full line.

BUG=707860
Review-Url: https://codereview.chromium.org/2791363002
Cr-Commit-Position: refs/heads/master@{#462831}
Committed: https://chromium.googlesource.com/chromium/src/+/4ba9b212af6288fea45140610770a198d0241a58

[Parastoo, 2017-04-03 18:27:01]

The CQ bit was checked by parastoog@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 18:27:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Parastoo, 2017-04-03 18:42:06]

Description was changed from

==========
A drop-down should take a line to be always aligend with text-fields.

BUG=
==========

to

==========
A drop-down field should take a line to be always aligned with text-fields. 

-- When we click on a text-field, the title text moves, so the best way to make
it permanently aligned is to make all the drop-down fields  take a full line.

BUG=707860
==========

[Parastoo, 2017-04-03 18:42:06]

parastoog@google.com changed reviewers:
+ sebsg@chromium.org

[Parastoo, 2017-04-03 18:44:58]

Description was changed from

==========
A drop-down field should take a line to be always aligned with text-fields. 

-- When we click on a text-field, the title text moves, so the best way to make
it permanently aligned is to make all the drop-down fields  take a full line.

BUG=707860
==========

to

==========
Align text-fields/drop-down fields on Payment Request form.

-- When we click on a text-field, the title text moves, so the best way
 to make it permanently aligned is to make all the drop-down fields
 take a full line.

BUG=707860
==========

[Parastoo, 2017-04-03 18:45:56]

Description was changed from

==========
Align text-fields/drop-down fields on Payment Request form.

-- When we click on a text-field, the title text moves, so the best way
 to make it permanently aligned is to make all the drop-down fields
 take a full line.

BUG=707860
==========

to

==========
Align text-fields/drop-down-fields on Payment Request form.

-- When we click on a text-field, the title text moves, so the best way
 to make it permanently aligned is to make all the drop-down fields
 take a full line.

BUG=707860
==========

[Parastoo, 2017-04-03 18:46:32]

parastoog@google.com changed reviewers:
+ mathp@chromium.org

[sebsg, 2017-04-03 19:13:36]

Nice!

Small comment

https://codereview.chromium.org/2791363002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java
(right):

https://codereview.chromium.org/2791363002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java:331:
useFullLine = nextFieldModel.isFullLine()
There is small change in behavior in your function. In the previous behavior, if
useFullLine was true, it could never be set to false in with the next field.
with your new one, if useFullLine was true, but the nextField is not a full line
nor a dropdown, you will set it to false. 

Maybe that was intended, if that was the case, all good. Otherwise, you should
probably do something like 

if (nextFieldModel.isFullLine() || nextFieldModel.getInputTypeHint() == ...)
  useFullLine = true;

[Parastoo, 2017-04-03 19:21:57]

The CQ bit was checked by parastoog@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 19:22:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Parastoo, 2017-04-03 19:27:19]

The CQ bit was checked by parastoog@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 19:27:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Parastoo, 2017-04-03 19:41:29]

https://codereview.chromium.org/2791363002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java
(right):

https://codereview.chromium.org/2791363002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java:331:
useFullLine = nextFieldModel.isFullLine()
My mistake :P

On 2017/04/03 19:13:36, sebsg wrote:
> There is small change in behavior in your function. In the previous behavior,
if
> useFullLine was true, it could never be set to false in with the next field.
> with your new one, if useFullLine was true, but the nextField is not a full
line
> nor a dropdown, you will set it to false. 
> 
> Maybe that was intended, if that was the case, all good. Otherwise, you should
> probably do something like 
> 
> if (nextFieldModel.isFullLine() || nextFieldModel.getInputTypeHint() == ...)
>   useFullLine = true;

Done.

[sebsg, 2017-04-03 19:56:31]

code LGTM, Can you add a screenshot of the new UI in the bug so everyone can
see? :)

[commit-bot: I haz the power, 2017-04-03 20:41:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 20:41:26]

Dry run: This issue passed the CQ dry run.

[Parastoo, 2017-04-03 20:49:32]

On 2017/04/03 19:56:31, sebsg wrote:
> code LGTM, Can you add a screenshot of the new UI in the bug so everyone can
> see? :)

Done.

[Mathieu, 2017-04-04 00:42:46]

lgtm

[Parastoo, 2017-04-04 14:08:03]

parastoog@google.com changed reviewers:
+ rouslan@chromium.org

[Parastoo, 2017-04-04 14:08:04]

rouslan@chromium.org: Please review changes in

[Parastoo, 2017-04-04 14:08:04]

rouslan@chromium.org: Please review changes in

[please use gerrit instead, 2017-04-04 14:41:54]

Screenshot?

[Parastoo, 2017-04-04 14:44:53]

On 2017/04/04 14:41:54, ಠ_ಠ wrote:
> Screenshot?

I added them to the bug description.

[please use gerrit instead, 2017-04-04 15:23:58]

This fix LGTM short term. Please work on a better solution next.

[Parastoo, 2017-04-07 10:06:05]

The CQ bit was checked by parastoog@google.com

[commit-bot: I haz the power, 2017-04-07 10:06:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 10:40:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491559565770470,
"parent_rev": "b1586e233f50e895739f3bcf2b028c230c16594a", "commit_rev":
"4ba9b212af6288fea45140610770a198d0241a58"}

[commit-bot: I haz the power, 2017-04-07 10:41:30]

Description was changed from

==========
Align text-fields/drop-down-fields on Payment Request form.

-- When we click on a text-field, the title text moves, so the best way
 to make it permanently aligned is to make all the drop-down fields
 take a full line.

BUG=707860
==========

to

==========
Align text-fields/drop-down-fields on Payment Request form.

-- When we click on a text-field, the title text moves, so the best way
 to make it permanently aligned is to make all the drop-down fields
 take a full line.

BUG=707860

Review-Url: https://codereview.chromium.org/2791363002
Cr-Commit-Position: refs/heads/master@{#462831}
Committed:
https://chromium.googlesource.com/chromium/src/+/4ba9b212af6288fea45140610770...
==========

[commit-bot: I haz the power, 2017-04-07 10:41:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4ba9b212af6288fea45140610770...

[sebsg, 2017-04-13 19:38:18]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2819623002/ by sebsg@chromium.org.

The reason for reverting is: The feature for which this CL was made was
reverted, and this CL breaks the UI of the credit card editor. Both should be
landed together when fixed..