Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2819613004: Disable HeapDeathTest.SameThreadCheck* tests on mac (Closed)

Created:
3 years, 8 months ago by keishi
Modified:
3 years, 8 months ago
Reviewers:
haraken, oilpan-reviews, sof
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable HeapDeathTest.SameThreadCheck* tests on mac Disabling HeapDeathTest.SameThreadCheck* because they occasionaly fail on mac bots. BUG=709069 Review-Url: https://codereview.chromium.org/2819613004 Cr-Commit-Position: refs/heads/master@{#464784} Committed: https://chromium.googlesource.com/chromium/src/+/43867c81dfd8e0b742015a3391e284753924648a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
keishi
The flakiness wasn't fixed with so disabling https://codereview.chromium.org/2804143004
3 years, 8 months ago (2017-04-14 09:46:26 UTC) #2
sof
lgtm
3 years, 8 months ago (2017-04-14 15:38:13 UTC) #4
haraken
LGTM
3 years, 8 months ago (2017-04-14 18:53:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819613004/1
3 years, 8 months ago (2017-04-14 20:09:33 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 20:16:34 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/43867c81dfd8e0b742015a3391e2...

Powered by Google App Engine
This is Rietveld 408576698