Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2804143004: Add DeathTest suffix to blink_heap_unittests same thread check tests (Closed)

Created:
3 years, 8 months ago by keishi
Modified:
3 years, 8 months ago
Reviewers:
haraken, oilpan-reviews
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DeathTest suffix to blink_heap_unittests same thread check tests Trying to fix flakiness in mac try bots. Assuming the flakiness is because the tests are running in a threaded context. Adding DeathTest suffix so the tests are run before other tests. BUG=709069 Review-Url: https://codereview.chromium.org/2804143004 Cr-Commit-Position: refs/heads/master@{#462787} Committed: https://chromium.googlesource.com/chromium/src/+/324a183e05ececfc2079f06c65c3757354f13fd1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
keishi
PTAL The tests seem to be ocasionally failing. All failures are showing the "Death tests ...
3 years, 8 months ago (2017-04-07 04:14:28 UTC) #2
haraken
LGTM
3 years, 8 months ago (2017-04-07 04:24:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804143004/1
3 years, 8 months ago (2017-04-07 04:53:18 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 06:01:56 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/324a183e05ececfc2079f06c65c3...

Powered by Google App Engine
This is Rietveld 408576698