Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java

Issue 2819593002: Revert of Expose resources in Robolectric/JUnit tests. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/BUILD.gn ('k') | testing/android/OWNERS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java
diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java
index 41da10bd71839b5034cba04d26e999efd3a296d0..4d2bec2a5a4e7ff28456363aa17d9256285b25ad 100644
--- a/chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java
+++ b/chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java
@@ -7,6 +7,7 @@
import static org.hamcrest.CoreMatchers.is;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertThat;
+import static org.junit.Assert.fail;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.anyBoolean;
import static org.mockito.ArgumentMatchers.anyInt;
@@ -18,8 +19,14 @@
import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.when;
+import android.content.Context;
+import android.content.res.Resources;
import android.graphics.Bitmap;
import android.graphics.Color;
+import android.support.annotation.ColorRes;
+import android.support.annotation.DimenRes;
+import android.support.annotation.LayoutRes;
+import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;
import android.widget.FrameLayout;
@@ -36,8 +43,12 @@
import org.mockito.stubbing.Answer;
import org.robolectric.RuntimeEnvironment;
import org.robolectric.annotation.Config;
+import org.robolectric.annotation.Implementation;
+import org.robolectric.annotation.Implements;
+import org.robolectric.shadows.ShadowResources;
import org.chromium.base.Callback;
+import org.chromium.chrome.R;
import org.chromium.chrome.browser.ChromeFeatureList;
import org.chromium.chrome.browser.Features;
import org.chromium.chrome.browser.favicon.LargeIconBridge.LargeIconCallback;
@@ -49,7 +60,9 @@
* Unit tests for {@link TileGroup}.
*/
@RunWith(LocalRobolectricTestRunner.class)
-@Config(manifest = Config.NONE)
+@Config(manifest = Config.NONE, sdk = 21,
+ shadows = {TileGroupTest.TileShadowResources.class,
+ TileGroupTest.ShadowLayoutInflater.class})
@Features(@Features.Register(ChromeFeatureList.NTP_OFFLINE_PAGES_FEATURE_NAME))
public class TileGroupTest {
private static final int MAX_TILES_TO_FETCH = 4;
@@ -417,4 +430,46 @@
@Override
public void destroy() {}
}
+
+ /**
+ * Replacement for the {@link Resources} to allow loading resources used by {@link TileGroup} in
+ * unit tests.
+ * TODO(https://crbug.com/693573): Needed until unit tests can pick up resources themselves.
+ */
+ @Implements(Resources.class)
+ public static class TileShadowResources extends ShadowResources {
+ @Implementation
+ public int getDimensionPixelSize(@DimenRes int id) {
+ if (id == R.dimen.tile_view_icon_size) return 48;
+
+ throw new IllegalArgumentException();
+ }
+
+ @Implementation
+ public int getColor(@ColorRes int id) {
+ if (id == R.color.default_favicon_background_color) return Color.BLACK;
+
+ throw new IllegalArgumentException();
+ }
+ }
+
+ /** Intercepts calls to inflate views to replace them with mocks. */
+ @Implements(LayoutInflater.class)
+ public static class ShadowLayoutInflater {
+ @Implementation
+ public static LayoutInflater from(Context context) {
+ LayoutInflater layoutInflater = mock(LayoutInflater.class);
+ when(layoutInflater.inflate(anyInt(), any(ViewGroup.class), anyBoolean()))
+ .thenAnswer(new Answer<View>() {
+ @Override
+ public View answer(InvocationOnMock invocation) throws Throwable {
+ @LayoutRes
+ int layoutId = invocation.getArgument(0);
+ if (layoutId != R.layout.tile_view) fail("Unexpected resource id.");
+ return createMockTileView();
+ }
+ });
+ return layoutInflater;
+ }
+ }
}
« no previous file with comments | « chrome/android/BUILD.gn ('k') | testing/android/OWNERS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698