Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2819503002: Revert of Enable crashpad for Mac (Closed)

Created:
3 years, 8 months ago by dvallet
Modified:
3 years, 8 months ago
Reviewers:
jzfeng, Matt Giuca, Sami
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable crashpad for Mac (patchset #4 id:60001 of https://codereview.chromium.org/2816593006/ ) Reason for revert: mac_chromium10.10_rel_ng buildbot failing in browsertests Original issue's description: > Enable crashpad for Mac. > > This follows the same logic as using breakpad in linux with flags --enable_crash-reporter and --crash-dumps-dir folders. > > For headless_shell target, we need to include the Helper crashpad_handler in the build. For --headless, this is already available in the framework bundle. > > BUG=687407 > > Review-Url: https://codereview.chromium.org/2816593006 > Cr-Commit-Position: refs/heads/master@{#464289} > Committed: https://chromium.googlesource.com/chromium/src/+/ecb2ad24952b077e71e56ba9d3edfc83c522f32a TBR=skyostil@chromium.org,jzfeng@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=687407 Review-Url: https://codereview.chromium.org/2819503002 Cr-Commit-Position: refs/heads/master@{#464308} Committed: https://chromium.googlesource.com/chromium/src/+/84d7dbe51cfa93499956ef7551eef7dd1a1a9ec9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -41 lines) Patch
M headless/BUILD.gn View 3 chunks +0 lines, -24 lines 0 comments Download
M headless/lib/headless_browser_browsertest.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M headless/lib/headless_content_main_delegate.cc View 3 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
dvallet
Created Revert of Enable crashpad for Mac
3 years, 8 months ago (2017-04-13 05:05:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819503002/1
3 years, 8 months ago (2017-04-13 05:05:43 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-13 05:05:45 UTC) #5
Matt Giuca
lgtm
3 years, 8 months ago (2017-04-13 05:09:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819503002/1
3 years, 8 months ago (2017-04-13 05:10:04 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 05:28:13 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/84d7dbe51cfa93499956ef7551ee...

Powered by Google App Engine
This is Rietveld 408576698