Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2819373002: Remove explicit -fomit_frame_pointer from ARM 32-bit builds. (Closed)

Created:
3 years, 8 months ago by Wez
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Remove explicit -fomit_frame_pointer from ARM 32-bit builds. -fomit_frame_pointer causes the assembly generated from SkEdge::setLine to trigger a CPU errata in ARM A12/A17 devices, so we are temporarily removing the flag until the toolchain can be fixed to avoid that. Revert this when issue 711784 is resolved. BUG=710131, 706654, 711784 Review-Url: https://codereview.chromium.org/2820803003 Cr-Commit-Position: refs/heads/master@{#464832} (cherry picked from commit bec44505ea17b6b8fbd366ab22ca724f3c448fe6) Review-Url: https://codereview.chromium.org/2819373002 . Cr-Commit-Position: refs/branch-heads/3071@{#26} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/3dcba7c1facb5bb49535476185c5a396669d52f0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M build/config/compiler/BUILD.gn View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Wez
3 years, 8 months ago (2017-04-17 22:21:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3dcba7c1facb5bb49535476185c5a396669d52f0.

Powered by Google App Engine
This is Rietveld 408576698