Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2820803003:
Remove explicit -fomit_frame_pointer from ARM 32-bit builds. (Closed)
DescriptionRemove explicit -fomit_frame_pointer from ARM 32-bit builds.
-fomit_frame_pointer causes the assembly generated from SkEdge::setLine
to trigger a CPU errata in ARM A12/A17 devices, so we are temporarily
removing the flag until the toolchain can be fixed to avoid that.
Revert this when issue 711784 is resolved.
BUG=710131, 706654, 711784
Review-Url: https://codereview.chromium.org/2820803003
Cr-Commit-Position: refs/heads/master@{#464832}
Committed: https://chromium.googlesource.com/chromium/src/+/bec44505ea17b6b8fbd366ab22ca724f3c448fe6
Patch Set 1 #Patch Set 2 : Omit frame pointers under Android #Messages
Total messages: 26 (16 generated)
The CQ bit was checked by wez@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
wez@chromium.org changed reviewers: + dpranke@chromium.org
Dirk, can you OWNERS this, plz?
Description was changed from ========== Remove explicit -fomit_frame_pointer from ARM 32-bit builds. -fomit_frame_pointer causes the assembly generated from SkEdge::setLine to trigger a CPU errata in ARM A12/A17 devices, so we are temporarily removing the flag until the toolchain can be fixed to avoid that. BUG=710131 ========== to ========== Remove explicit -fomit_frame_pointer from ARM 32-bit builds. -fomit_frame_pointer causes the assembly generated from SkEdge::setLine to trigger a CPU errata in ARM A12/A17 devices, so we are temporarily removing the flag until the toolchain can be fixed to avoid that. BUG=710131, 706654 ==========
lgtm, though I'm not the best person to review this. cc'ing erikchen and primiano as an fyi ...
Description was changed from ========== Remove explicit -fomit_frame_pointer from ARM 32-bit builds. -fomit_frame_pointer causes the assembly generated from SkEdge::setLine to trigger a CPU errata in ARM A12/A17 devices, so we are temporarily removing the flag until the toolchain can be fixed to avoid that. BUG=710131, 706654 ========== to ========== Remove explicit -fomit_frame_pointer from ARM 32-bit builds. -fomit_frame_pointer causes the assembly generated from SkEdge::setLine to trigger a CPU errata in ARM A12/A17 devices, so we are temporarily removing the flag until the toolchain can be fixed to avoid that. BUG=710131, 706654, 711784 ==========
Description was changed from ========== Remove explicit -fomit_frame_pointer from ARM 32-bit builds. -fomit_frame_pointer causes the assembly generated from SkEdge::setLine to trigger a CPU errata in ARM A12/A17 devices, so we are temporarily removing the flag until the toolchain can be fixed to avoid that. BUG=710131, 706654, 711784 ========== to ========== Remove explicit -fomit_frame_pointer from ARM 32-bit builds. -fomit_frame_pointer causes the assembly generated from SkEdge::setLine to trigger a CPU errata in ARM A12/A17 devices, so we are temporarily removing the flag until the toolchain can be fixed to avoid that. Revert this when issue 711784 is resolved. BUG=710131, 706654, 711784 ==========
On 2017/04/14 21:23:16, Dirk Pranke wrote: > lgtm, though I'm not the best person to review this. cc'ing erikchen and > primiano as an fyi ... Thanks Dirk!
The CQ bit was unchecked by wez@chromium.org
The CQ bit was checked by wez@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by wez@chromium.org
The CQ bit was checked by wez@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2820803003/#ps20001 (title: "Omit frame pointers under Android")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
FYI: Tweaked patch to continue to omit frame pointers in Android builds, since that was the case prior to https://codereview.chromium.org/2782063005/
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by wez@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492212023231780,
"parent_rev": "875fdf2dbc234ca80ded492af8671f3194f8239b", "commit_rev":
"bec44505ea17b6b8fbd366ab22ca724f3c448fe6"}
Message was sent while issue was closed.
Description was changed from ========== Remove explicit -fomit_frame_pointer from ARM 32-bit builds. -fomit_frame_pointer causes the assembly generated from SkEdge::setLine to trigger a CPU errata in ARM A12/A17 devices, so we are temporarily removing the flag until the toolchain can be fixed to avoid that. Revert this when issue 711784 is resolved. BUG=710131, 706654, 711784 ========== to ========== Remove explicit -fomit_frame_pointer from ARM 32-bit builds. -fomit_frame_pointer causes the assembly generated from SkEdge::setLine to trigger a CPU errata in ARM A12/A17 devices, so we are temporarily removing the flag until the toolchain can be fixed to avoid that. Revert this when issue 711784 is resolved. BUG=710131, 706654, 711784 Review-Url: https://codereview.chromium.org/2820803003 Cr-Commit-Position: refs/heads/master@{#464832} Committed: https://chromium.googlesource.com/chromium/src/+/bec44505ea17b6b8fbd366ab22ca... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/bec44505ea17b6b8fbd366ab22ca...
Message was sent while issue was closed.
erikchen@chromium.org changed reviewers: + erikchen@chromium.org
Message was sent while issue was closed.
lgtm |
