Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2819273002: Improve Learn Mode for braille (Closed)

Created:
3 years, 8 months ago by David Tseng
Modified:
3 years, 8 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, alemate+watch_chromium.org, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dougt+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve Learn Mode for braille - output dots ... chord, when we don't have a mapping and a user presses a chord combination - when a user types a dot pattern, back-translate the pattern using the current braille table and output. For example, if a user presses dot 4 in English computer braille, they will hear "@". - when a user types a chord that maps to a command or modifier, they will receive that as output. For example, "control" (dots 2-5 chord), "backspace" (dot 7 chord) TEST=open Learn Mode. Press various braille keys. BUG=707927, 707940 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2819273002 Cr-Commit-Position: refs/heads/master@{#465231} Committed: https://chromium.googlesource.com/chromium/src/+/d8bfbee9bffdb2827fc28d84dc44c13c349ce317

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -7 lines) Patch
M chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer.js View 3 chunks +46 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (6 generated)
David Tseng
3 years, 8 months ago (2017-04-17 18:25:18 UTC) #4
dmazzoni
lgtm
3 years, 8 months ago (2017-04-18 04:20:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819273002/1
3 years, 8 months ago (2017-04-18 12:29:31 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 14:28:41 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d8bfbee9bffdb2827fc28d84dc44...

Powered by Google App Engine
This is Rietveld 408576698