Support braille dot or chorded typing conversions to standard keyboard keys

Support braille dot or chorded typing conversions to standard keyboard keys

This cl enables flexible keyboard commands from a braille display perkins keyboard.

Incrmental modifier typing:
A user can press the following keys to build a shortcut
- space+dots 2-5: control
space+dots 3-6: alt
space+dots 3-7: shift

for convenience:
- space+dots 2-5-7: control+shift
space+dots 3-6-7: alt+shift

For example:
type space+dots 3-7, space+dots 3-6, dots 3-4-5 (s) to move to the status tray. Alternatively, press space+dots 3-6-7, dots 3-4-5 (s).

It is now possible to perform common commands like alt+f, ctrl+1-9, and more.

Chorded key mappings:
space+dot 7: backspace
space+dots 3-5: tab
space+dots 1-3-5-6: escape
space+dots 4-6: enter
These set of commands do not require a incremental modifier be pressed previously.

TEST=invoke various modifiers
ctrl+l, alt+f, ctrl+t, alt+shift+l, and more. Verify the expected action occurs.
In addition, use chorded commands such as tab, escape, shift+tab (mixture of the two types above). Verify expected action occurs.

BUG=707940, 707937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2817313002
Cr-Commit-Position: refs/heads/master@{#464984}
Committed: https://chromium.googlesource.com/chromium/src/+/566a5a2b7579c276d818914b2f30688960c3aa98

[David Tseng, 2017-04-14 22:25:55]

Description was changed from

==========
Support braille dot or chorded typing conversions to standard keyboard keys

This cl enables flexible keyboard commands from a braille display perkins
keyboard.

Incrmental modifier typing:
A user can press the following keys to build a shortcut
- space+dots 2-5: control
space+dots 3-6: alt
space+dots 3-7: shift

for convenience:
- space+dots 2-5-7: control+shift
space+dots 3-6-7: alt+shift

For example:
type space+dots 3-7, space+dots 3-6, dots 3-4-5 (s) to move to the status tray.
Alternatively, press space+dots 3-6-7, dots 3-4-5 (s).

It is now possible to perform common commands like alt+f, ctrl+1-9, and more.

Chorded key mappings:
space+dot 7: backspace
space+dots 3-5: tab
space+dots 1-3-5-6: escape
space+dots 4-6: enter
These set of commands do not require a incremental modifier be pressed
previously.

TEST=invoke various modifiers
ctrl+l, alt+f, ctrl+t, alt+shift+l, and more. Verify the expected action occurs.
In addition, use chorded commands such as tab, escape, shift+tab (mixture of the
two types above). Verify expected action occurs.

BUG=
==========

to

==========
Support braille dot or chorded typing conversions to standard keyboard keys

This cl enables flexible keyboard commands from a braille display perkins
keyboard.

Incrmental modifier typing:
A user can press the following keys to build a shortcut
- space+dots 2-5: control
space+dots 3-6: alt
space+dots 3-7: shift

for convenience:
- space+dots 2-5-7: control+shift
space+dots 3-6-7: alt+shift

For example:
type space+dots 3-7, space+dots 3-6, dots 3-4-5 (s) to move to the status tray.
Alternatively, press space+dots 3-6-7, dots 3-4-5 (s).

It is now possible to perform common commands like alt+f, ctrl+1-9, and more.

Chorded key mappings:
space+dot 7: backspace
space+dots 3-5: tab
space+dots 1-3-5-6: escape
space+dots 4-6: enter
These set of commands do not require a incremental modifier be pressed
previously.

TEST=invoke various modifiers
ctrl+l, alt+f, ctrl+t, alt+shift+l, and more. Verify the expected action occurs.
In addition, use chorded commands such as tab, escape, shift+tab (mixture of the
two types above). Verify expected action occurs.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2017-04-14 22:26:48]

Description was changed from

==========
Support braille dot or chorded typing conversions to standard keyboard keys

This cl enables flexible keyboard commands from a braille display perkins
keyboard.

Incrmental modifier typing:
A user can press the following keys to build a shortcut
- space+dots 2-5: control
space+dots 3-6: alt
space+dots 3-7: shift

for convenience:
- space+dots 2-5-7: control+shift
space+dots 3-6-7: alt+shift

For example:
type space+dots 3-7, space+dots 3-6, dots 3-4-5 (s) to move to the status tray.
Alternatively, press space+dots 3-6-7, dots 3-4-5 (s).

It is now possible to perform common commands like alt+f, ctrl+1-9, and more.

Chorded key mappings:
space+dot 7: backspace
space+dots 3-5: tab
space+dots 1-3-5-6: escape
space+dots 4-6: enter
These set of commands do not require a incremental modifier be pressed
previously.

TEST=invoke various modifiers
ctrl+l, alt+f, ctrl+t, alt+shift+l, and more. Verify the expected action occurs.
In addition, use chorded commands such as tab, escape, shift+tab (mixture of the
two types above). Verify expected action occurs.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Support braille dot or chorded typing conversions to standard keyboard keys

This cl enables flexible keyboard commands from a braille display perkins
keyboard.

Incrmental modifier typing:
A user can press the following keys to build a shortcut
- space+dots 2-5: control
space+dots 3-6: alt
space+dots 3-7: shift

for convenience:
- space+dots 2-5-7: control+shift
space+dots 3-6-7: alt+shift

For example:
type space+dots 3-7, space+dots 3-6, dots 3-4-5 (s) to move to the status tray.
Alternatively, press space+dots 3-6-7, dots 3-4-5 (s).

It is now possible to perform common commands like alt+f, ctrl+1-9, and more.

Chorded key mappings:
space+dot 7: backspace
space+dots 3-5: tab
space+dots 1-3-5-6: escape
space+dots 4-6: enter
These set of commands do not require a incremental modifier be pressed
previously.

TEST=invoke various modifiers
ctrl+l, alt+f, ctrl+t, alt+shift+l, and more. Verify the expected action occurs.
In addition, use chorded commands such as tab, escape, shift+tab (mixture of the
two types above). Verify expected action occurs.

BUG=707940
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2017-04-14 22:26:48]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2017-04-17 04:53:25]

lgtm

https://codereview.chromium.org/2817313002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/chromevox/braille/braille_key_event_sequence_reducer.js
(right):

https://codereview.chromium.org/2817313002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/braille/braille_key_event_sequence_reducer.js:20:
/** @private {Object} */
Use a more specific type. Looks like a nullable record with fields altKey,
ctrlKey, shiftKey.

https://codereview.chromium.org/2817313002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/braille/braille_key_event_sequence_reducer.js:73:
evt.shiftKey = this.incrementalKey_.shiftKey;
Would be nice to support Search too in a future change; I'm thinking mainly for
non-ChromeVox shortcuts

https://codereview.chromium.org/2817313002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/braille/braille_key_event_sequence_reducer.js:74:
this.incrementalKey_ = null;
Why not just set it to {} here and then you don't need line 44:
this.incrementalKey_ = this.incrementalKey_ || {};

Or have a helper method reset_() that sets altKey, ctrlKey, and shiftKey to
false.

https://codereview.chromium.org/2817313002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/braille/braille_key_types.js
(right):

https://codereview.chromium.org/2817313002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/braille/braille_key_types.js:127:
0b1010: 'I',
nit: indent

https://codereview.chromium.org/2817313002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/braille/braille_key_types.js:143:
0b111101: 'Y',
nit: indent

https://codereview.chromium.org/2817313002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/braille/braille_key_types.js:175:
0b1010010: {ctrlKey: true, shiftKey: true},
Can you sequence ctrl and shift instead? I wonder if it'd be better to
force users to do that just to not use up too many chords...

[David Tseng, 2017-04-17 16:10:51]

https://codereview.chromium.org/2817313002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/chromevox/braille/braille_key_event_sequence_reducer.js
(right):

https://codereview.chromium.org/2817313002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/braille/braille_key_event_sequence_reducer.js:74:
this.incrementalKey_ = null;
On 2017/04/17 04:53:25, dmazzoni wrote:
> Why not just set it to {} here and then you don't need line 44:
> this.incrementalKey_ = this.incrementalKey_ || {};
> 
> Or have a helper method reset_() that sets altKey, ctrlKey, and shiftKey to
> false.
> 

Actually, the null state is important.

I've:
- renamed the class to BrailleKeyEventRewriter
- made the first "reste" of the incremental key set to null

The issue is that we sometimes don't want to make any changes to the incoming
braille key event if it doesn't meet any of the criteria for re-mapping (i.e.
having a dot or chord pattern we want to remap). In those cases, we should clear
the incremental key and not rewrite the event (even to our own defaults, which
might interfere).

https://codereview.chromium.org/2817313002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/braille/braille_key_types.js
(right):

https://codereview.chromium.org/2817313002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/braille/braille_key_types.js:127:
0b1010: 'I',
On 2017/04/17 04:53:25, dmazzoni wrote:
> nit: indent

Done.

https://codereview.chromium.org/2817313002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/braille/braille_key_types.js:143:
0b111101: 'Y',
On 2017/04/17 04:53:25, dmazzoni wrote:
> nit: indent

Done.

https://codereview.chromium.org/2817313002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/braille/braille_key_types.js:175:
0b1010010: {ctrlKey: true, shiftKey: true},
On 2017/04/17 04:53:25, dmazzoni wrote:
> Can you sequence ctrl and shift instead? I wonder if it'd be better to
> force users to do that just to not use up too many chords...


I do think 2-5, 3-6 are pretty nice chords and should be reserved for something
pretty important. 
These are usually mapped to "read current character and read current word".
I am open to other chords. As far as adding dot 7 to each for shift, I do think
it important enough considering that alt-shift-letter is so prominent in system
shortcuts.

[David Tseng, 2017-04-17 16:17:06]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 16:17:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 17:25:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 17:25:13]

Dry run: This issue passed the CQ dry run.

[David Tseng, 2017-04-17 19:35:03]

Description was changed from

==========
Support braille dot or chorded typing conversions to standard keyboard keys

This cl enables flexible keyboard commands from a braille display perkins
keyboard.

Incrmental modifier typing:
A user can press the following keys to build a shortcut
- space+dots 2-5: control
space+dots 3-6: alt
space+dots 3-7: shift

for convenience:
- space+dots 2-5-7: control+shift
space+dots 3-6-7: alt+shift

For example:
type space+dots 3-7, space+dots 3-6, dots 3-4-5 (s) to move to the status tray.
Alternatively, press space+dots 3-6-7, dots 3-4-5 (s).

It is now possible to perform common commands like alt+f, ctrl+1-9, and more.

Chorded key mappings:
space+dot 7: backspace
space+dots 3-5: tab
space+dots 1-3-5-6: escape
space+dots 4-6: enter
These set of commands do not require a incremental modifier be pressed
previously.

TEST=invoke various modifiers
ctrl+l, alt+f, ctrl+t, alt+shift+l, and more. Verify the expected action occurs.
In addition, use chorded commands such as tab, escape, shift+tab (mixture of the
two types above). Verify expected action occurs.

BUG=707940
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Support braille dot or chorded typing conversions to standard keyboard keys

This cl enables flexible keyboard commands from a braille display perkins
keyboard.

Incrmental modifier typing:
A user can press the following keys to build a shortcut
- space+dots 2-5: control
space+dots 3-6: alt
space+dots 3-7: shift

for convenience:
- space+dots 2-5-7: control+shift
space+dots 3-6-7: alt+shift

For example:
type space+dots 3-7, space+dots 3-6, dots 3-4-5 (s) to move to the status tray.
Alternatively, press space+dots 3-6-7, dots 3-4-5 (s).

It is now possible to perform common commands like alt+f, ctrl+1-9, and more.

Chorded key mappings:
space+dot 7: backspace
space+dots 3-5: tab
space+dots 1-3-5-6: escape
space+dots 4-6: enter
These set of commands do not require a incremental modifier be pressed
previously.

TEST=invoke various modifiers
ctrl+l, alt+f, ctrl+t, alt+shift+l, and more. Verify the expected action occurs.
In addition, use chorded commands such as tab, escape, shift+tab (mixture of the
two types above). Verify expected action occurs.

BUG=707940,707937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2017-04-17 19:35:13]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2017-04-17 19:35:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2817313002/#ps20001
(title: "Address feedback.")

[commit-bot: I haz the power, 2017-04-17 19:35:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 19:41:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492457713129930,
"parent_rev": "4e89ee1bd9be30cc5566fa434004a763d0610c82", "commit_rev":
"566a5a2b7579c276d818914b2f30688960c3aa98"}

[commit-bot: I haz the power, 2017-04-17 19:41:21]

Description was changed from

==========
Support braille dot or chorded typing conversions to standard keyboard keys

This cl enables flexible keyboard commands from a braille display perkins
keyboard.

Incrmental modifier typing:
A user can press the following keys to build a shortcut
- space+dots 2-5: control
space+dots 3-6: alt
space+dots 3-7: shift

for convenience:
- space+dots 2-5-7: control+shift
space+dots 3-6-7: alt+shift

For example:
type space+dots 3-7, space+dots 3-6, dots 3-4-5 (s) to move to the status tray.
Alternatively, press space+dots 3-6-7, dots 3-4-5 (s).

It is now possible to perform common commands like alt+f, ctrl+1-9, and more.

Chorded key mappings:
space+dot 7: backspace
space+dots 3-5: tab
space+dots 1-3-5-6: escape
space+dots 4-6: enter
These set of commands do not require a incremental modifier be pressed
previously.

TEST=invoke various modifiers
ctrl+l, alt+f, ctrl+t, alt+shift+l, and more. Verify the expected action occurs.
In addition, use chorded commands such as tab, escape, shift+tab (mixture of the
two types above). Verify expected action occurs.

BUG=707940,707937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Support braille dot or chorded typing conversions to standard keyboard keys

This cl enables flexible keyboard commands from a braille display perkins
keyboard.

Incrmental modifier typing:
A user can press the following keys to build a shortcut
- space+dots 2-5: control
space+dots 3-6: alt
space+dots 3-7: shift

for convenience:
- space+dots 2-5-7: control+shift
space+dots 3-6-7: alt+shift

For example:
type space+dots 3-7, space+dots 3-6, dots 3-4-5 (s) to move to the status tray.
Alternatively, press space+dots 3-6-7, dots 3-4-5 (s).

It is now possible to perform common commands like alt+f, ctrl+1-9, and more.

Chorded key mappings:
space+dot 7: backspace
space+dots 3-5: tab
space+dots 1-3-5-6: escape
space+dots 4-6: enter
These set of commands do not require a incremental modifier be pressed
previously.

TEST=invoke various modifiers
ctrl+l, alt+f, ctrl+t, alt+shift+l, and more. Verify the expected action occurs.
In addition, use chorded commands such as tab, escape, shift+tab (mixture of the
two types above). Verify expected action occurs.

BUG=707940,707937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2817313002
Cr-Commit-Position: refs/heads/master@{#464984}
Committed:
https://chromium.googlesource.com/chromium/src/+/566a5a2b7579c276d818914b2f30...
==========

[commit-bot: I haz the power, 2017-04-17 19:41:23]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/566a5a2b7579c276d818914b2f30...