Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2819233002: Image Capture: Reject applyConstraints() if passed an unsupported constraint (Closed)

Created:
3 years, 8 months ago by mcasas
Modified:
3 years, 8 months ago
CC:
chromium-reviews, blink-reviews, mcasas+imagecapture_chromium.org
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Image Capture: Reject applyConstraints() if passed an unsupported constraint This CL adds a check to reject applyConstraints() if it is passed an unsupported constraint. LayoutTests gets an updated, albeit a bit a cumbersome one because they hit an unrelated bug (https://crbug.com/711524). BUG=711694 Review-Url: https://codereview.chromium.org/2819653003 Cr-Commit-Position: refs/heads/master@{#464820} (cherry picked from commit 635372d1d6a0318a44dbc1be736d8060a126d68a) NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2819233002 Cr-Commit-Position: refs/branch-heads/3071@{#13} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/dfb6460559869ea71010b5c5df456e63858d401b

Patch Set 1 #

Messages

Total messages: 19 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819233002/1
3 years, 8 months ago (2017-04-17 15:00:11 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-17 15:00:13 UTC) #4
mcasas
reillyg@ RS plz (this CL is a merge-to-branch)
3 years, 8 months ago (2017-04-17 15:01:05 UTC) #6
haraken
rs LGTM
3 years, 8 months ago (2017-04-17 15:01:59 UTC) #7
mcasas
On 2017/04/17 15:01:59, haraken wrote: > rs LGTM thanks haraken@ !
3 years, 8 months ago (2017-04-17 15:25:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819233002/1
3 years, 8 months ago (2017-04-17 15:25:45 UTC) #10
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 8 months ago (2017-04-17 15:25:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819233002/1
3 years, 8 months ago (2017-04-17 15:26:38 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/dfb6460559869ea71010b5c5df456e63858d401b
3 years, 8 months ago (2017-04-17 15:27:20 UTC) #18
Reilly Grant (use Gerrit)
3 years, 8 months ago (2017-04-17 15:43:59 UTC) #19
Message was sent while issue was closed.
lgtm but if you have merge approval you can generally TBR

Powered by Google App Engine
This is Rietveld 408576698