Image Capture: Reject applyConstraints() if passed an unsupported constraint

Image Capture: Reject applyConstraints() if passed an unsupported constraint

This CL adds a check to reject applyConstraints() if it is passed an
unsupported constraint. LayoutTests gets an updated, albeit a bit a 
cumbersome one because they hit an unrelated bug (https://crbug.com/711524).

BUG=711694
Review-Url: https://codereview.chromium.org/2819653003
Cr-Commit-Position: refs/heads/master@{#464820}
Committed: https://chromium.googlesource.com/chromium/src/+/635372d1d6a0318a44dbc1be736d8060a126d68a

[mcasas, 2017-04-14 17:39:51]

Patchset #1 (id:1) has been deleted

[mcasas, 2017-04-14 17:41:52]

Description was changed from

==========
Image Capture: Reject applyConstraints() if passed an unsupported constraint

This CL adds a check to reject applyConstraints() if it is passed an
unsupported constraint. LayoutTests updated, albeit a bit cumbersome
because they hit an unrelated bug (https://crbug.com/711524).

BUG=711694
==========

to

==========
Image Capture: Reject applyConstraints() if passed an unsupported constraint

This CL adds a check to reject applyConstraints() if it is passed an
unsupported constraint. LayoutTests gets an updated, albeit a bit a 
cumbersome one because they hit an unrelated bug (https://crbug.com/711524).

BUG=711694
==========

[mcasas, 2017-04-14 17:42:09]

mcasas@chromium.org changed reviewers:
+ reillyg@chromium.org

[mcasas, 2017-04-14 17:42:10]

reillyg@ PTAL

[Reilly Grant (use Gerrit), 2017-04-14 19:46:18]

lgtm with nits

https://codereview.chromium.org/2819653003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints-getSettings.html
(right):

https://codereview.chromium.org/2819653003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints-getSettings.html:56:
// kicked right after creation, we introduce a small delay to allow for
same here

https://codereview.chromium.org/2819653003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints.html
(right):

https://codereview.chromium.org/2819653003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints.html:52:
// kicked right after creation, we introduce a small delay to allow for
Missing words? Should be "|videoTrack|'s capabilities, just like the actual
capture, are gathered in a process kicked off right after creation"

https://codereview.chromium.org/2819653003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints.html:55:
return new Promise((resolve) => setTimeout(resolve, 100));
nit: no parenthesis around a single argument

https://codereview.chromium.org/2819653003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-getCapabilities.html
(right):

https://codereview.chromium.org/2819653003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-getCapabilities.html:37:
// kicked right after creation, we introduce a small delay to allow for
Ah, I see the comments were copied from here.

[mcasas, 2017-04-14 21:21:27]

https://codereview.chromium.org/2819653003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints-getSettings.html
(right):

https://codereview.chromium.org/2819653003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints-getSettings.html:56:
// kicked right after creation, we introduce a small delay to allow for
On 2017/04/14 19:46:17, Reilly Grant wrote:
> same here

Done.

https://codereview.chromium.org/2819653003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints.html
(right):

https://codereview.chromium.org/2819653003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints.html:52:
// kicked right after creation, we introduce a small delay to allow for
On 2017/04/14 19:46:17, Reilly Grant wrote:
> Missing words? Should be "|videoTrack|'s capabilities, just like the actual
> capture, are gathered in a process kicked off right after creation"

Rewritten, here and in the next file.

https://codereview.chromium.org/2819653003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints.html:55:
return new Promise((resolve) => setTimeout(resolve, 100));
On 2017/04/14 19:46:17, Reilly Grant wrote:
> nit: no parenthesis around a single argument

Done.

https://codereview.chromium.org/2819653003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-getCapabilities.html
(right):

https://codereview.chromium.org/2819653003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-getCapabilities.html:37:
// kicked right after creation, we introduce a small delay to allow for
On 2017/04/14 19:46:18, Reilly Grant wrote:
> Ah, I see the comments were copied from here.

Acknowledged.

[mcasas, 2017-04-14 21:25:00]

Patchset #2 (id:40001) has been deleted

[mcasas, 2017-04-14 21:27:08]

Patchset #2 (id:60001) has been deleted

[mcasas, 2017-04-14 21:27:14]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2017-04-14 21:27:14]

The patchset sent to the CQ was uploaded after l-g-t-m from reillyg@chromium.org
Link to the patchset: https://codereview.chromium.org/2819653003/#ps80001
(title: "reillyg@s comments")

[commit-bot: I haz the power, 2017-04-14 21:27:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 23:19:01]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492205234337960,
"parent_rev": "ae72f92d7caba6d32ba2a11f32943f29af15c3d8", "commit_rev":
"635372d1d6a0318a44dbc1be736d8060a126d68a"}

[commit-bot: I haz the power, 2017-04-14 23:19:53]

Description was changed from

==========
Image Capture: Reject applyConstraints() if passed an unsupported constraint

This CL adds a check to reject applyConstraints() if it is passed an
unsupported constraint. LayoutTests gets an updated, albeit a bit a 
cumbersome one because they hit an unrelated bug (https://crbug.com/711524).

BUG=711694
==========

to

==========
Image Capture: Reject applyConstraints() if passed an unsupported constraint

This CL adds a check to reject applyConstraints() if it is passed an
unsupported constraint. LayoutTests gets an updated, albeit a bit a 
cumbersome one because they hit an unrelated bug (https://crbug.com/711524).

BUG=711694

Review-Url: https://codereview.chromium.org/2819653003
Cr-Commit-Position: refs/heads/master@{#464820}
Committed:
https://chromium.googlesource.com/chromium/src/+/635372d1d6a0318a44dbc1be736d...
==========

[commit-bot: I haz the power, 2017-04-14 23:19:54]

Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/635372d1d6a0318a44dbc1be736d...