Issue 2818933002: chrome/android: Enable gcm upstream by default for invalidations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2818933002: chrome/android: Enable gcm upstream by default for invalidations. (Closed)

Created:
3 years, 8 months ago by Khushal

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3029

Project:
chromium

Visibility:
Public.

chrome/android: Enable gcm upstream by default for invalidations. The feature is hidden behind a field trial check. Enable it by default. BUG=711485 Review-Url: https://codereview.chromium.org/2814403003 Cr-Commit-Position: refs/heads/master@{#464632} (cherry picked from commit 18a9048f37ca12fa560fd989d837a0de0974f88e) Review-Url: https://codereview.chromium.org/2818933002 . Cr-Commit-Position: refs/branch-heads/3029@{#705} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/8cd018cea1a13992c64343d41bb546a76828ff1d

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -27 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java	View		4 chunks	+4 lines, -13 lines	0 comments	Download
	M	chrome/android/junit/src/org/chromium/chrome/browser/invalidation/InvalidationControllerTest.java	View		14 chunks	+14 lines, -14 lines	0 comments	Download

Total messages: 2 (1 generated)

Khushal

3 years, 8 months ago (2017-04-14 02:35:20 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8cd018cea1a13992c64343d41bb546a76828ff1d.