chrome/android: Enable gcm upstream by default for invalidations.

chrome/android: Enable gcm upstream by default for invalidations.

The feature is hidden behind a field trial check. Enable it by default.

BUG=711485
Review-Url: https://codereview.chromium.org/2814403003
Cr-Commit-Position: refs/heads/master@{#464632}
Committed: https://chromium.googlesource.com/chromium/src/+/18a9048f37ca12fa560fd989d837a0de0974f88e

[Khushal, 2017-04-13 22:55:50]

khushalsagar@chromium.org changed reviewers:
+ zea@chromium.org

[Khushal, 2017-04-13 22:56:08]

khushalsagar@chromium.org changed reviewers:
+ nyquist@chromium.org

[Nicolas Zea, 2017-04-13 22:58:25]

lgtm. Are we separately re-enabling the experiment for m58?

[Khushal, 2017-04-13 23:02:39]

On 2017/04/13 22:58:25, Nicolas Zea wrote:
> lgtm. Are we separately re-enabling the experiment for m58?

Would it be better to merge this to 58?

We would still need to re-enable the experiment for all the prior versions. This
feature goes back to 46.

[Khushal, 2017-04-13 23:02:47]

The CQ bit was checked by khushalsagar@chromium.org

[commit-bot: I haz the power, 2017-04-13 23:03:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nicolas Zea, 2017-04-13 23:03:49]

On 2017/04/13 23:02:39, Khushal wrote:
> On 2017/04/13 22:58:25, Nicolas Zea wrote:
> > lgtm. Are we separately re-enabling the experiment for m58?
> 
> Would it be better to merge this to 58?
> 
> We would still need to re-enable the experiment for all the prior versions.
This
> feature goes back to 46.

If we can get it into 58 sure. I'll give amineer a heads up

[commit-bot: I haz the power, 2017-04-13 23:26:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 23:26:02]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Khushal, 2017-04-13 23:38:34]

nyquist@, could you take a look at the test change?

[nyquist, 2017-04-14 00:09:16]

The CQ bit was checked by nyquist@chromium.org

[nyquist, 2017-04-14 00:09:17]

lgtm

[nyquist, 2017-04-14 00:09:18]

The patchset sent to the CQ was uploaded after l-g-t-m from zea@chromium.org
Link to the patchset: https://codereview.chromium.org/2814403003/#ps40001
(title: "tests")

[commit-bot: I haz the power, 2017-04-14 00:10:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 00:50:55]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492128556553640,
"parent_rev": "fd5066f1508cbc41e12be6e26e3f45078039f393", "commit_rev":
"18a9048f37ca12fa560fd989d837a0de0974f88e"}

[commit-bot: I haz the power, 2017-04-14 00:51:48]

Description was changed from

==========
chrome/android: Enable gcm upstream by default for invalidations.

The feature is hidden behind a field trial check. Enable it by default.

BUG=711485
==========

to

==========
chrome/android: Enable gcm upstream by default for invalidations.

The feature is hidden behind a field trial check. Enable it by default.

BUG=711485

Review-Url: https://codereview.chromium.org/2814403003
Cr-Commit-Position: refs/heads/master@{#464632}
Committed:
https://chromium.googlesource.com/chromium/src/+/18a9048f37ca12fa560fd989d837...
==========

[commit-bot: I haz the power, 2017-04-14 00:51:49]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/18a9048f37ca12fa560fd989d837...