Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2818703002: Shorten LayoutSelectionStartEnd() call stack (Closed)

Created:
3 years, 8 months ago by yoichio
Modified:
3 years, 8 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Shorten LayoutSelectionStartEnd() call stack LayoutObject calls FrameSelection::LayoutSelectionStartEnd() via LayoutView. Let's call it directly. BUG=708453 Review-Url: https://codereview.chromium.org/2818703002 Cr-Commit-Position: refs/heads/master@{#464674} Committed: https://chromium.googlesource.com/chromium/src/+/1210f0f9a5941ce09b2ece0c4d2c593ef64986e5

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
yoichio
3 years, 8 months ago (2017-04-13 08:57:52 UTC) #7
yosin_UTC9
lgtm Other usage of FrameSelection in LayoutObject is for SelectionColor() and SelectionBackgroundColor(). At this time, ...
3 years, 8 months ago (2017-04-13 09:13:17 UTC) #8
yoichio
Kent, could take a look?
3 years, 8 months ago (2017-04-13 09:26:16 UTC) #10
tkent
lgtm
3 years, 8 months ago (2017-04-13 09:32:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818703002/1
3 years, 8 months ago (2017-04-13 10:46:24 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/410295)
3 years, 8 months ago (2017-04-13 10:53:49 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818703002/20001
3 years, 8 months ago (2017-04-14 02:07:52 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 04:08:19 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1210f0f9a5941ce09b2ece0c4d2c...

Powered by Google App Engine
This is Rietveld 408576698