Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutView.cpp

Issue 2818703002: Shorten LayoutSelectionStartEnd() call stack (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutView.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc.
4 * All rights reserved. 4 * All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 604 matching lines...) Expand 10 before | Expand all | Expand 10 after
615 615
616 bool LayoutView::HasPendingSelection() const { 616 bool LayoutView::HasPendingSelection() const {
617 return frame_view_->GetFrame().Selection().IsAppearanceDirty(); 617 return frame_view_->GetFrame().Selection().IsAppearanceDirty();
618 } 618 }
619 619
620 void LayoutView::CommitPendingSelection() { 620 void LayoutView::CommitPendingSelection() {
621 TRACE_EVENT0("blink", "LayoutView::commitPendingSelection"); 621 TRACE_EVENT0("blink", "LayoutView::commitPendingSelection");
622 frame_view_->GetFrame().Selection().CommitAppearanceIfNeeded(*this); 622 frame_view_->GetFrame().Selection().CommitAppearanceIfNeeded(*this);
623 } 623 }
624 624
625 void LayoutView::SelectionStartEnd(int& start_pos, int& end_pos) {
626 frame_view_->GetFrame().Selection().LayoutSelectionStartEnd(start_pos,
627 end_pos);
628 }
629
630 bool LayoutView::ShouldUsePrintingLayout() const { 625 bool LayoutView::ShouldUsePrintingLayout() const {
631 if (!GetDocument().Printing() || !frame_view_) 626 if (!GetDocument().Printing() || !frame_view_)
632 return false; 627 return false;
633 return frame_view_->GetFrame().ShouldUsePrintingLayout(); 628 return frame_view_->GetFrame().ShouldUsePrintingLayout();
634 } 629 }
635 630
636 LayoutRect LayoutView::ViewRect() const { 631 LayoutRect LayoutView::ViewRect() const {
637 if (ShouldUsePrintingLayout()) 632 if (ShouldUsePrintingLayout())
638 return LayoutRect(LayoutPoint(), Size()); 633 return LayoutRect(LayoutPoint(), Size());
639 if (frame_view_) 634 if (frame_view_)
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
822 // Frame scroll corner is painted using LayoutView as the display item client. 817 // Frame scroll corner is painted using LayoutView as the display item client.
823 if (!RuntimeEnabledFeatures::rootLayerScrollingEnabled() && 818 if (!RuntimeEnabledFeatures::rootLayerScrollingEnabled() &&
824 (GetFrameView()->HorizontalScrollbar() || 819 (GetFrameView()->HorizontalScrollbar() ||
825 GetFrameView()->VerticalScrollbar())) 820 GetFrameView()->VerticalScrollbar()))
826 return false; 821 return false;
827 822
828 return LayoutBlockFlow::PaintedOutputOfObjectHasNoEffectRegardlessOfSize(); 823 return LayoutBlockFlow::PaintedOutputOfObjectHasNoEffectRegardlessOfSize();
829 } 824 }
830 825
831 } // namespace blink 826 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutView.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698