Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2818633003:
ChromeOS OOBE: fix JS crash in oobe-dialog focus behavior. (Closed)
|
Created:
3 years, 8 months ago by Alexander Alekseev Modified:
3 years, 8 months ago CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionChromeOS OOBE: fix JS crash in oobe-dialog focus behavior.
BUG=707939
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2818633003
Cr-Commit-Position: refs/heads/master@{#464609}
Committed: https://chromium.googlesource.com/chromium/src/+/b6ca3d65b4a1d2653384a84a62f7dde590dbbe4f
Patch Set 1 #
Messages
Total messages: 24 (12 generated)
Description was changed from ========== ChromeOS OOBE: fix JS crash in oobe-dialog focus behavior. BUG=707939 ========== to ========== ChromeOS OOBE: fix JS crash in oobe-dialog focus behavior. BUG=707939 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
alemate@chromium.org changed reviewers: + levarum@chromium.org
Please review.
The CQ bit was checked by alemate@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by alemate@chromium.org
The CQ bit was checked by alemate@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
alemate@chromium.org changed reviewers: + achuith@chromium.org - levarum@chromium.org
Please review.
alemate@chromium.org changed reviewers: + jdufault@chromium.org
Jacob, Please review.
lgtm
The CQ bit was checked by alemate@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/04/13 23:10:25, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
lgtm
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1492124978065890, "parent_rev":
"d1ed2867ffe879d6e1e404cb99c0a9713d7c3eb4", "commit_rev":
"b6ca3d65b4a1d2653384a84a62f7dde590dbbe4f"}
Message was sent while issue was closed.
Description was changed from ========== ChromeOS OOBE: fix JS crash in oobe-dialog focus behavior. BUG=707939 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== ChromeOS OOBE: fix JS crash in oobe-dialog focus behavior. BUG=707939 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2818633003 Cr-Commit-Position: refs/heads/master@{#464609} Committed: https://chromium.googlesource.com/chromium/src/+/b6ca3d65b4a1d2653384a84a62f7... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b6ca3d65b4a1d2653384a84a62f7... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
