chrome/browser/resources/chromeos/login/oobe_dialog.js - Issue 2818633003: ChromeOS OOBE: fix JS crash in oobe-dialog focus behavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/login/oobe_dialog.js

Issue 2818633003: ChromeOS OOBE: fix JS crash in oobe-dialog focus behavior. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/chromeos/login/oobe_dialog.js

diff --git a/chrome/browser/resources/chromeos/login/oobe_dialog.js b/chrome/browser/resources/chromeos/login/oobe_dialog.js

index fc5ad21f78e19a436e2b3bd8ac360143e7c15df5..7dc9d22bc7524ef86de1a794bf04a9dc0516a9e5 100644

--- a/chrome/browser/resources/chromeos/login/oobe_dialog.js

+++ b/chrome/browser/resources/chromeos/login/oobe_dialog.js

@@ -39,7 +39,7 @@ Polymer({

show: function() {

var focusedElements = this.getElementsByClassName('focus-on-show');

- if (focusedElements)

+ if (focusedElements.length > 0)

focusedElements[0].focus();

this.fire('show-dialog');

« no previous file with comments | « no previous file | no next file » | no next file with comments »