Improved isInteresting heuristic, made more AutomationNodes focusable

Improved isInteresting heuristic, made more AutomationNodes focusable

BUG=593885, 710559
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2818503002
Cr-Commit-Position: refs/heads/master@{#464184}
Committed: https://chromium.googlesource.com/chromium/src/+/db7f879ab02ada7f66b0aa955d1658482cc3af2c

[elichtenberg, 2017-04-12 17:14:22]

Description was changed from

==========
Improved isInteresting heuristic, made more AutomationNodes focusable

BUG=593885
==========

to

==========
Improved isInteresting heuristic, made more AutomationNodes focusable

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[elichtenberg, 2017-04-12 17:15:48]

Description was changed from

==========
Improved isInteresting heuristic, made more AutomationNodes focusable

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Improved isInteresting heuristic, made more AutomationNodes focusable

BUG=593885,710559
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[elichtenberg, 2017-04-12 17:17:33]

The CQ bit was checked by elichtenberg@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 17:18:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[elichtenberg, 2017-04-12 17:19:02]

elichtenberg@google.com changed reviewers:
+ dmazzoni@chromium.org, dtseng@chromium.org

[David Tseng, 2017-04-12 17:37:46]

lgtm

https://codereview.chromium.org/2818503002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/switch_access/tree_walker.js (right):

https://codereview.chromium.org/2818503002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/switch_access/tree_walker.js:136: &&
parent.role === chrome.automation.RoleType.TAB_LIST)
Note that these roles can occur in web pages as well. I would still check
focusability if the root is not DESKTOP if that's your intent here.

[commit-bot: I haz the power, 2017-04-12 17:39:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 17:39:09]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[elichtenberg, 2017-04-12 20:11:04]

https://codereview.chromium.org/2818503002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/switch_access/tree_walker.js (right):

https://codereview.chromium.org/2818503002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/switch_access/tree_walker.js:136: &&
parent.role === chrome.automation.RoleType.TAB_LIST)
On 2017/04/12 17:37:46, David Tseng wrote:
> Note that these roles can occur in web pages as well. I would still check
> focusability if the root is not DESKTOP if that's your intent here.

Done.

[elichtenberg, 2017-04-12 20:11:28]

The CQ bit was checked by elichtenberg@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 20:12:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2017-04-12 20:30:42]

lgtm

[commit-bot: I haz the power, 2017-04-12 21:11:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 21:11:02]

Dry run: This issue passed the CQ dry run.

[elichtenberg, 2017-04-12 22:23:19]

The CQ bit was checked by elichtenberg@google.com

[elichtenberg, 2017-04-12 22:23:19]

The patchset sent to the CQ was uploaded after l-g-t-m from dtseng@chromium.org
Link to the patchset: https://codereview.chromium.org/2818503002/#ps40001
(title: "Responded to comment")

[commit-bot: I haz the power, 2017-04-12 22:24:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 22:48:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492035799108540,
"parent_rev": "558591d592e4b10227f574ee2f6b4d97b33218b9", "commit_rev":
"db7f879ab02ada7f66b0aa955d1658482cc3af2c"}

[commit-bot: I haz the power, 2017-04-12 22:49:47]

Description was changed from

==========
Improved isInteresting heuristic, made more AutomationNodes focusable

BUG=593885,710559
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Improved isInteresting heuristic, made more AutomationNodes focusable

BUG=593885,710559
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2818503002
Cr-Commit-Position: refs/heads/master@{#464184}
Committed:
https://chromium.googlesource.com/chromium/src/+/db7f879ab02ada7f66b0aa955d16...
==========

[commit-bot: I haz the power, 2017-04-12 22:49:51]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/db7f879ab02ada7f66b0aa955d16...