Improved isInteresting heuristic, made more AutomationNodes focusable

chrome/browser/resources/chromeos/switch_access/tree_walker_unittest.gtestjs

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Test fixture for tree_walker.js.
  * @constructor
  * @extends {testing.Test}
  */
 function AutomationTreeWalkerUnitTest () {
   testing.Test.call(this);
 };
 
 AutomationTreeWalkerUnitTest.prototype = {
   __proto__: testing.Test.prototype,
 
   /** @override */
   extraLibraries: [
     'tree_walker.js',
   ],
 
   /** @override */
   browsePreload: DUMMY_URL,
 
   getSampleTree: function() {
+    let loc = {left: 0, top: 0, width: 0, height: 0};
     // root
     //   middle1
     //     leaf1
     //     leaf2
     //     leaf3
     //   middle2
     //     leaf4
     //     leaf5
-    let root = {};
-    let middle1 = {};
-    let middle2 = {};
-    let leaf1 = {};
-    let leaf2 = {};
-    let leaf3 = {};
-    let leaf4 = {};
-    let leaf5 = {};
+    let root = {location: loc, state: {}};
+    let middle1 = {location: loc, state: {}};
+    let middle2 = {location: loc, state: {}};
+    let leaf1 = {location: loc, state: {}};
+    let leaf2 = {location: loc, state: {}};
+    let leaf3 = {location: loc, state: {}};
+    let leaf4 = {location: loc, state: {}};
+    let leaf5 = {location: loc, state: {}};
 
     root.firstChild = middle1;
     root.lastChild = middle2;
 
     middle1.parent = root;
     middle2.parent = root;
     middle1.nextSibling = middle2;
     middle2.previousSibling = middle1;
     middle1.firstChild = leaf1;
     middle1.lastChild = leaf3;
@@ skipping 20 matching lines @@
       leaf1: leaf1,
       leaf2: leaf2,
       leaf3: leaf3,
       leaf4: leaf4,
       leaf5: leaf5
     };
   }
 };
 
 TEST_F('AutomationTreeWalkerUnitTest', 'MoveToNode', function() {
+  chrome.automation = {
+    RoleType: {DESKTOP: 'desktop', TAB: 'tab', TAB_LIST: 'tabList'},
+    StateType: {FOCUSABLE: 'focusable', OFFSCREEN: 'offscreen'}
+  };
+
   let t = this.getSampleTree();
   let treeWalker = new AutomationTreeWalker();
 
   let interesting = {focusable: true};
   t.leaf1.state = interesting;
   t.leaf2.state = interesting;
   t.middle2.state = interesting;
   t.leaf5.state = interesting;
 
   // Move to next node.
@@ skipping 55 matching lines @@
   assertEquals(t.leaf3, treeWalker.getYoungestDescendant_(t.middle1));
   assertEquals(t.leaf5, treeWalker.getYoungestDescendant_(t.middle2));
   assertEquals(undefined, treeWalker.getYoungestDescendant_(t.leaf1));
   assertEquals(undefined, treeWalker.getYoungestDescendant_(t.leaf2));
   assertEquals(undefined, treeWalker.getYoungestDescendant_(t.leaf3));
   assertEquals(undefined, treeWalker.getYoungestDescendant_(t.leaf4));
   assertEquals(undefined, treeWalker.getYoungestDescendant_(t.leaf5));
 });
 
 TEST_F('AutomationTreeWalkerUnitTest', 'IsInteresting', function() {
-  let node1 = {};
-  let node2 = {state: {}};
-  let node3 = {state: {focusable: false}};
-  let node4 = {state: {focusable: true}};
+  chrome.automation = {
+    RoleType: {DESKTOP: 'desktop', TAB: 'tab', TAB_LIST: 'tabList'},
+    StateType: {FOCUSABLE: 'focusable', OFFSCREEN: 'offscreen'}
+  };
+
   let treeWalker = new AutomationTreeWalker();
 
-  assertTrue(treeWalker.isInteresting_(node1) === undefined);
-  assertTrue(treeWalker.isInteresting_(node2) === undefined);
-  assertFalse(treeWalker.isInteresting_(node3));
-  assertTrue(treeWalker.isInteresting_(node4));
+  // Testing focusable.
+  let loc1 = {left: 0, top: 0, width: 0, height: 0};
+  let node1 = {location: loc1, state: {}};
+  let node2 = {location: loc1, state: {focusable: false}};
+  let node3 = {location: loc1, state: {focusable: true}};
+  assertFalse(treeWalker.isInteresting_(node1));
+  assertFalse(treeWalker.isInteresting_(node2));
+  assertTrue(treeWalker.isInteresting_(node3));
+
+  // Testing onscreen.
+  let loc2 = {left: -1, top: 0, width: 0, height: 0};
+  let loc3 = {left: 0, top: -1, width: 0, height: 0};
+  let node4 = {location: loc2, state: {focusable: true}};
+  let node5 = {location: loc3, state: {focusable: true}};
+  assertFalse(treeWalker.isInteresting_(node4));
+  assertFalse(treeWalker.isInteresting_(node5));
+
+  // Testing if tab.
+  let node6 = {location: loc1, role: 'desktop', state: {}};
+  let node7 = {location: loc1, role: 'tabList', state: {}};
+  let node8 =
+      {location: loc1, parent: node7, root: node6, role: 'tab', state: {}};
+  assertFalse(treeWalker.isInteresting_(node6));
+  assertFalse(treeWalker.isInteresting_(node7));
+  assertTrue(treeWalker.isInteresting_(node8));
 });