Remove unnecessary virtual ManagePasswordsTest::view().

Remove unnecessary virtual ManagePasswordsTest::view().

It only complicates things.

BUG=711012
Review-Url: https://codereview.chromium.org/2818383004
Cr-Commit-Position: refs/heads/master@{#465430}
Committed: https://chromium.googlesource.com/chromium/src/+/deadadaac4e84f4229d5e4d80ac04cef9dd060bc

[tapted, 2017-04-18 07:24:32]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 07:24:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2017-04-18 07:26:24]

Description was changed from

==========
Remove unnecessary virtual ManagePasswordsTest::view().

BUG=711012
==========

to

==========
Remove unnecessary virtual ManagePasswordsTest::view().

It only complicates things.

BUG=711012
==========

[tapted, 2017-04-18 07:26:24]

tapted@chromium.org changed reviewers:
+ pkasting@chromium.org

[tapted, 2017-04-18 07:33:12]

Hi Peter, please take a look

[commit-bot: I haz the power, 2017-04-18 07:48:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 07:48:49]

Dry run: This issue passed the CQ dry run.

[Peter Kasting, 2017-04-18 20:49:48]

LGTM

https://codereview.chromium.org/2818383004/diff/1/chrome/browser/ui/views/pas...
File
chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc
(right):

https://codereview.chromium.org/2818383004/diff/1/chrome/browser/ui/views/pas...
chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc:66:
using ManagePasswordsBubbleViewTest = ManagePasswordsTest;
Nit: Just nuke this and use the shorter name below?

[tapted, 2017-04-18 21:36:41]

https://codereview.chromium.org/2818383004/diff/1/chrome/browser/ui/views/pas...
File
chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc
(right):

https://codereview.chromium.org/2818383004/diff/1/chrome/browser/ui/views/pas...
chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc:66:
using ManagePasswordsBubbleViewTest = ManagePasswordsTest;
On 2017/04/18 20:49:48, Peter Kasting wrote:
> Nit: Just nuke this and use the shorter name below?

I think the `using` approach is the convention we normally follow for these,
since it forms the test name prefix. ManagePasswordsBubbleViewTest is a closer
match to the filename --
 manage_passwords_bubble_view_interactive_uitest.cc -- which makes the test file
easier to find when all you have is the test name like
ManagePasswordsBubbleViewTest.BasicOpenAndClose. Using `ManagePasswordsTest`
could also mean that the same prefix appears in multiple files.

[tapted, 2017-04-18 23:51:33]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2017-04-18 23:52:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2017-04-19 00:14:15]

The CQ bit was unchecked by tapted@chromium.org

[tapted, 2017-04-19 00:15:35]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2017-04-19 00:16:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 00:25:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492560935829770, "parent_rev":
"97198dd14f4ec3dbbe17629a928acb64c02f01d0", "commit_rev":
"deadadaac4e84f4229d5e4d80ac04cef9dd060bc"}

[commit-bot: I haz the power, 2017-04-19 00:25:49]

Description was changed from

==========
Remove unnecessary virtual ManagePasswordsTest::view().

It only complicates things.

BUG=711012
==========

to

==========
Remove unnecessary virtual ManagePasswordsTest::view().

It only complicates things.

BUG=711012

Review-Url: https://codereview.chromium.org/2818383004
Cr-Commit-Position: refs/heads/master@{#465430}
Committed:
https://chromium.googlesource.com/chromium/src/+/deadadaac4e84f4229d5e4d80ac0...
==========

[commit-bot: I haz the power, 2017-04-19 00:25:50]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/deadadaac4e84f4229d5e4d80ac0...