Remove unnecessary virtual ManagePasswordsTest::view().

chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc

Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc
index 6baa1e945acc0fdc4910e921f6d1e19a392be9db..1579d11594006ac20772438262888c2444e7c8bc 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc
+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc
@@ -63,21 +63,7 @@ bool IsBubbleShowing() {
 
 namespace metrics_util = password_manager::metrics_util;
 
-class ManagePasswordsBubbleViewTest : public ManagePasswordsTest {
- public:
-  ManagePasswordsBubbleViewTest() {}
-  ~ManagePasswordsBubbleViewTest() override {}
-
-  ManagePasswordsIconView* view() override {
-    BrowserView* browser_view = static_cast<BrowserView*>(browser()->window());
-    return browser_view->toolbar()
-        ->location_bar()
-        ->manage_passwords_icon_view();
-  }
-
- private:
-  DISALLOW_COPY_AND_ASSIGN(ManagePasswordsBubbleViewTest);
-};
+using ManagePasswordsBubbleViewTest = ManagePasswordsTest;

[Peter Kasting, 2017/04/18 20:49:48]

Nit: Just nuke this and use the shorter name below?

[tapted, 2017/04/18 21:36:40]

I think the `using` approach is the convention we normally follow for these,
since it forms the test name prefix. ManagePasswordsBubbleViewTest is a closer
match to the filename --
 manage_passwords_bubble_view_interactive_uitest.cc -- which makes the test file
easier to find when all you have is the test name like
ManagePasswordsBubbleViewTest.BasicOpenAndClose. Using `ManagePasswordsTest`
could also mean that the same prefix appears in multiple files.

 
 IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest, BasicOpenAndClose) {
   EXPECT_FALSE(IsBubbleShowing());