MD Settings: Focus cookies search field when exiting cookie details subpage.

MD Settings: Focus cookies search field when exiting cookie details subpage.

Also, this CL fixes adjusts the subpage exiting focus logic to only trigger on
history pop navigations.

BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2817903004
Cr-Commit-Position: refs/heads/master@{#464598}
Committed: https://chromium.googlesource.com/chromium/src/+/7637b493cfa07ff94534102c5a719e57d6f273a5

[dpapad, 2017-04-13 19:36:50]

Description was changed from

==========
MD Settings: Trigger subpage exiting focus logic only on history pop
navigations.

BUG=709586
==========

to

==========
MD Settings: Trigger subpage exiting focus logic only on history pop
navigations.

BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-04-13 19:37:12]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 19:37:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 20:17:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 20:17:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dpapad, 2017-04-13 20:52:04]

Description was changed from

==========
MD Settings: Trigger subpage exiting focus logic only on history pop
navigations.

BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Focus cookies search field when exiting cookies detais subpage.

Also, this CL fixes adjusts the subpage exiting focus logic to only trigger on
history pop navigations.

BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-04-13 20:53:30]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 20:54:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-04-13 21:01:04]

dpapad@chromium.org changed reviewers:
+ tommycli@chromium.org

[dpapad, 2017-04-13 21:01:05]

Thanks for the consultation. It really helped.

https://codereview.chromium.org/2817903004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_data.js (right):

https://codereview.chromium.org/2817903004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_data.js:41: observer:
'focusConfigChanged_',
FYI, this pattern of populating the focusConfig passed from the parent is also
used at
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/site_s....

[dpapad, 2017-04-13 21:03:24]

Description was changed from

==========
MD Settings: Focus cookies search field when exiting cookies detais subpage.

Also, this CL fixes adjusts the subpage exiting focus logic to only trigger on
history pop navigations.

BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Focus cookies search field when exiting cookie details subpage.

Also, this CL fixes adjusts the subpage exiting focus logic to only trigger on
history pop navigations.

BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2017-04-13 21:11:02]

lgtm thanks for video and comments. makes review easy

[dpapad, 2017-04-13 21:14:51]

The CQ bit was unchecked by dpapad@chromium.org

[dpapad, 2017-04-13 21:14:52]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2017-04-13 21:14:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-04-13 21:54:48]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2017-04-13 21:54:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2817903004/#ps40001
(title: "Simulate pop state in test.")

[commit-bot: I haz the power, 2017-04-13 21:55:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-04-13 21:56:16]

https://codereview.chromium.org/2817903004/diff/40001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/settings_animated_pages_test.js (right):

https://codereview.chromium.org/2817903004/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/settings/settings_animated_pages_test.js:28:
settings.navigateTo(settings.Route.BASIC);
Updated test to simulate the "pop" state, now that it is required for the code
being tested to execute. Also gave <settings-animated-pages> a real |section|
name, so now I was able to remove the manual assignment to |selected| at line
22. This is better since the code being tested is supposed to set that in
currentRouteChanged.

[commit-bot: I haz the power, 2017-04-13 23:14:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492120488731560,
"parent_rev": "04fd4a9cb77d7952d20236c2b57f8e4467e6ca7b", "commit_rev":
"7637b493cfa07ff94534102c5a719e57d6f273a5"}

[commit-bot: I haz the power, 2017-04-13 23:15:01]

Description was changed from

==========
MD Settings: Focus cookies search field when exiting cookie details subpage.

Also, this CL fixes adjusts the subpage exiting focus logic to only trigger on
history pop navigations.

BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Focus cookies search field when exiting cookie details subpage.

Also, this CL fixes adjusts the subpage exiting focus logic to only trigger on
history pop navigations.

BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2817903004
Cr-Commit-Position: refs/heads/master@{#464598}
Committed:
https://chromium.googlesource.com/chromium/src/+/7637b493cfa07ff94534102c5a71...
==========

[commit-bot: I haz the power, 2017-04-13 23:15:03]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7637b493cfa07ff94534102c5a71...