Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6294)

Unified Diff: chrome/test/data/webui/settings/settings_animated_pages_test.js

Issue 2817903004: MD Settings: Focus cookies search field when exiting cookie details subpage. (Closed)
Patch Set: Simulate pop state in test. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/site_settings_page/site_settings_page.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/settings_animated_pages_test.js
diff --git a/chrome/test/data/webui/settings/settings_animated_pages_test.js b/chrome/test/data/webui/settings/settings_animated_pages_test.js
index fd47f641a397826fb65caef2a02606d79e124a3a..1b2052e63527fc26d9fbcb2d441f3e07837fbd15 100644
--- a/chrome/test/data/webui/settings/settings_animated_pages_test.js
+++ b/chrome/test/data/webui/settings/settings_animated_pages_test.js
@@ -5,7 +5,8 @@
suite('settings-animated-pages', function() {
test('focuses subpage trigger when exiting subpage', function(done) {
document.body.innerHTML = `
- <settings-animated-pages section="test-section">
+ <settings-animated-pages
+ section="${settings.Route.SEARCH_ENGINES.section}">
<neon-animatable route-path="default">
<button id="subpage-trigger"></button>
</neon-animatable>
@@ -19,14 +20,13 @@ suite('settings-animated-pages', function() {
animatedPages.focusConfig.set(
settings.Route.SEARCH_ENGINES.path, '#subpage-trigger');
- animatedPages.$.animatedPages.selected = settings.Route.SEARCH_ENGINES.path;
-
var trigger = document.body.querySelector('#subpage-trigger');
assertTrue(!!trigger);
trigger.addEventListener('focus', function() { done(); });
- // Trigger subpage exit.
- animatedPages.currentRouteChanged(
- settings.Route.BASIC, settings.Route.SEARCH_ENGINES);
+ // Trigger subpage exit navigation.
+ settings.navigateTo(settings.Route.BASIC);
dpapad 2017/04/13 21:56:16 Updated test to simulate the "pop" state, now that
+ settings.navigateTo(settings.Route.SEARCH_ENGINES);
+ settings.navigateToPreviousRoute();
});
});
« no previous file with comments | « chrome/browser/resources/settings/site_settings_page/site_settings_page.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698