Make progress notifications an alert.

Make progress notifications an alert.

 - send them to the xpc service
 - remove a DCHECK in the handler since it's a situation that can in
   fact happen when updating an extension notification and it's safe.

BUG=

Review-Url: https://codereview.chromium.org/2817813006
Cr-Commit-Position: refs/heads/master@{#464453}
Committed: https://chromium.googlesource.com/chromium/src/+/19da2957967998c8c9fcf43534f26d4f6297d24b

[Miguel Garcia, 2017-04-13 13:54:40]

The CQ bit was checked by miguelg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 13:54:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Miguel Garcia, 2017-04-13 13:55:52]

miguelg@chromium.org changed reviewers:
+ peter@chromium.org

[Miguel Garcia, 2017-04-13 13:59:00]

Description was changed from

==========
Make progress notifications an alert.

 - send them to the xpc service
 - remove a DCHECK in the handler since it's a situation that can in
   fact happen when updating an extension notification and it's safe.

BUG=
==========

to

==========
Make progress notifications an alert.

 - send them to the xpc service
 - remove a DCHECK in the handler since it's a situation that can in
   fact happen when updating an extension notification and it's safe.

BUG=
==========

[Peter Beverloo, 2017-04-13 14:14:14]

lgtm

https://codereview.chromium.org/2817813006/diff/1/chrome/browser/notification...
File chrome/browser/notifications/non_persistent_notification_handler.cc (left):

https://codereview.chromium.org/2817813006/diff/1/chrome/browser/notification...
chrome/browser/notifications/non_persistent_notification_handler.cc:45:
DCHECK_EQ(notifications_.count(notification_id), 0u);
ohhh I guess this is invalid for replacements, right?

https://codereview.chromium.org/2817813006/diff/1/chrome/browser/notification...
File chrome/browser/notifications/notification_platform_bridge_mac.mm (right):

https://codereview.chromium.org/2817813006/diff/1/chrome/browser/notification...
chrome/browser/notifications/notification_platform_bridge_mac.mm:250: if
(notification.never_timeout() || notification.progress() > 0) {
Please detail why we're doing this in the comment above.

https://codereview.chromium.org/2817813006/diff/1/chrome/browser/notification...
File chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm
(right):

https://codereview.chromium.org/2817813006/diff/1/chrome/browser/notification...
chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm:262:
EXPECT_EQ(1u, [displayedAlerts count]);
micro nit: ASSERT_EQ

[commit-bot: I haz the power, 2017-04-13 14:38:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 14:38:53]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Miguel Garcia, 2017-04-13 16:36:14]

The CQ bit was checked by miguelg@chromium.org

[Miguel Garcia, 2017-04-13 16:36:15]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/2817813006/#ps20001
(title: "review")

[Miguel Garcia, 2017-04-13 16:36:19]

https://codereview.chromium.org/2817813006/diff/1/chrome/browser/notification...
File chrome/browser/notifications/non_persistent_notification_handler.cc (left):

https://codereview.chromium.org/2817813006/diff/1/chrome/browser/notification...
chrome/browser/notifications/non_persistent_notification_handler.cc:45:
DCHECK_EQ(notifications_.count(notification_id), 0u);
On 2017/04/13 14:14:14, Peter Beverloo wrote:
> ohhh I guess this is invalid for replacements, right?

Acknowledged.

https://codereview.chromium.org/2817813006/diff/1/chrome/browser/notification...
File chrome/browser/notifications/notification_platform_bridge_mac.mm (right):

https://codereview.chromium.org/2817813006/diff/1/chrome/browser/notification...
chrome/browser/notifications/notification_platform_bridge_mac.mm:250: if
(notification.never_timeout() || notification.progress() > 0) {
On 2017/04/13 14:14:14, Peter Beverloo wrote:
> Please detail why we're doing this in the comment above.

Done.

https://codereview.chromium.org/2817813006/diff/1/chrome/browser/notification...
File chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm
(right):

https://codereview.chromium.org/2817813006/diff/1/chrome/browser/notification...
chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm:262:
EXPECT_EQ(1u, [displayedAlerts count]);
On 2017/04/13 14:14:14, Peter Beverloo wrote:
> micro nit: ASSERT_EQ

Done.

[commit-bot: I haz the power, 2017-04-13 16:36:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 17:29:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492101374950090,
"parent_rev": "6f3ee4aef9982d1c5579bd78ac12895ffc161f45", "commit_rev":
"19da2957967998c8c9fcf43534f26d4f6297d24b"}

[commit-bot: I haz the power, 2017-04-13 17:30:21]

Description was changed from

==========
Make progress notifications an alert.

 - send them to the xpc service
 - remove a DCHECK in the handler since it's a situation that can in
   fact happen when updating an extension notification and it's safe.

BUG=
==========

to

==========
Make progress notifications an alert.

 - send them to the xpc service
 - remove a DCHECK in the handler since it's a situation that can in
   fact happen when updating an extension notification and it's safe.

BUG=

Review-Url: https://codereview.chromium.org/2817813006
Cr-Commit-Position: refs/heads/master@{#464453}
Committed:
https://chromium.googlesource.com/chromium/src/+/19da2957967998c8c9fcf43534f2...
==========

[commit-bot: I haz the power, 2017-04-13 17:30:23]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/19da2957967998c8c9fcf43534f2...