Make progress notifications an alert.

chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <AppKit/AppKit.h>
 #import <objc/runtime.h>
 
 #include "base/bind.h"
 #include "base/i18n/number_formatting.h"
 #include "base/mac/scoped_nsobject.h"
@@ skipping 237 matching lines @@
       CreateBanner("Title", "Context", "https://gmail.com", nullptr, nullptr);
   const int kSamplePercent = 10;
 
   notification->set_progress(kSamplePercent);
 
   std::unique_ptr<NotificationPlatformBridgeMac> bridge(
       new NotificationPlatformBridgeMac(notification_center(),
                                         alert_dispatcher()));
   bridge->Display(NotificationCommon::PERSISTENT, "notification_id",
                   "profile_id", false, *notification);
-  NSArray* notifications = [notification_center() deliveredNotifications];
 
-  EXPECT_EQ(1u, [notifications count]);
+  // Progress notifications are considered alerts
+  EXPECT_EQ(0u, [[notification_center() deliveredNotifications] count]);
+  NSArray* displayedAlerts = [alert_dispatcher() alerts];
+  EXPECT_EQ(1u, [displayedAlerts count]);

[Peter Beverloo, 2017/04/13 14:14:14]

micro nit: ASSERT_EQ

[Miguel Garcia, 2017/04/13 16:36:19]

Done.

 
-  NSUserNotification* delivered_notification = [notifications objectAtIndex:0];
+  NSUserNotification* delivered_notification =
+      [displayedAlerts objectAtIndex:0];
   base::string16 expected =
       base::FormatPercent(kSamplePercent) + base::UTF8ToUTF16(" - Title");
   EXPECT_NSEQ(base::SysUTF16ToNSString(expected),
               [delivered_notification title]);
 }
 
 TEST_F(NotificationPlatformBridgeMacTest, TestCloseNotification) {
   std::unique_ptr<Notification> notification = CreateBanner(
       "Title", "Context", "https://gmail.com", "Button 1", nullptr);
 
@@ skipping 138 matching lines @@
     bridge->Display(NotificationCommon::PERSISTENT, "notification_id2",
                     "profile_id", false, *alert);
     EXPECT_EQ(1u, [[notification_center() deliveredNotifications] count]);
     EXPECT_EQ(1u, [[alert_dispatcher() alerts] count]);
   }
 
   // The destructor of the bridge should close all notifications.
   EXPECT_EQ(0u, [[notification_center() deliveredNotifications] count]);
   EXPECT_EQ(0u, [[alert_dispatcher() alerts] count]);
 }