Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 2817813003: supersize: Add "diff" command (Closed)

Created:
3 years, 8 months ago by agrieve
Modified:
3 years, 8 months ago
Reviewers:
estevenson
CC:
chromium-reviews, wnwen+watch_chromium.org, estevenson+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

supersize: Add "diff" command And marginally improved LazyPath output_directory logic to look for build.ninja rather than "Release" in the name. BUG=681694 Review-Url: https://codereview.chromium.org/2817813003 Cr-Commit-Position: refs/heads/master@{#464462} Committed: https://chromium.googlesource.com/chromium/src/+/98d419b9b3e36419388ff6ce042da6e123fc841f

Patch Set 1 #

Patch Set 2 : update readme, change old/new -> before/after #

Patch Set 3 : rebase #

Total comments: 2

Patch Set 4 : review commetns #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -152 lines) Patch
M tools/binary_size/README.md View 1 2 3 2 chunks +14 lines, -6 lines 0 comments Download
M tools/binary_size/libsupersize/archive.py View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/binary_size/libsupersize/console.py View 3 chunks +7 lines, -8 lines 0 comments Download
M tools/binary_size/libsupersize/describe.py View 1 1 chunk +8 lines, -8 lines 0 comments Download
M tools/binary_size/libsupersize/integration_test.py View 3 chunks +20 lines, -3 lines 0 comments Download
M tools/binary_size/libsupersize/main.py View 1 2 chunks +20 lines, -0 lines 0 comments Download
M tools/binary_size/libsupersize/models.py View 1 10 chunks +52 lines, -49 lines 0 comments Download
M tools/binary_size/libsupersize/paths.py View 2 chunks +12 lines, -12 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/ActualDiff.golden View 1 2 chunks +45 lines, -45 lines 0 comments Download
A tools/binary_size/libsupersize/testdata/Console.golden View 1 chunk +116 lines, -0 lines 0 comments Download
D tools/binary_size/libsupersize/testdata/ConsoleNullDiff.golden View 1 chunk +0 lines, -20 lines 0 comments Download
A + tools/binary_size/libsupersize/testdata/Diff_NullDiff.golden View 0 chunks +-1 lines, --1 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
agrieve
On 2017/04/13 14:03:52, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:estevenson@chromium.org 🚢
3 years, 8 months ago (2017-04-13 14:04:04 UTC) #3
estevenson
lgtm https://codereview.chromium.org/2817813003/diff/40001/tools/binary_size/README.md File tools/binary_size/README.md (right): https://codereview.chromium.org/2817813003/diff/40001/tools/binary_size/README.md#newcode48 tools/binary_size/README.md:48: tools/binary_size/supersize console chrome.size --query='Print(size_info)' nit: exclude "diff" from ...
3 years, 8 months ago (2017-04-13 16:54:25 UTC) #4
agrieve
https://codereview.chromium.org/2817813003/diff/40001/tools/binary_size/README.md File tools/binary_size/README.md (right): https://codereview.chromium.org/2817813003/diff/40001/tools/binary_size/README.md#newcode48 tools/binary_size/README.md:48: tools/binary_size/supersize console chrome.size --query='Print(size_info)' On 2017/04/13 16:54:25, estevenson wrote: ...
3 years, 8 months ago (2017-04-13 17:40:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817813003/60001
3 years, 8 months ago (2017-04-13 17:42:29 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 17:55:29 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/98d419b9b3e36419388ff6ce042d...

Powered by Google App Engine
This is Rietveld 408576698