Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: tools/binary_size/libsupersize/describe.py

Issue 2817813003: supersize: Add "diff" command (Closed)
Patch Set: review commetns Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/binary_size/libsupersize/console.py ('k') | tools/binary_size/libsupersize/integration_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/binary_size/libsupersize/describe.py
diff --git a/tools/binary_size/libsupersize/describe.py b/tools/binary_size/libsupersize/describe.py
index b4cf6a718a6a411a96ce275402038d04533806d2..bf689d574c66e8ad3ae14cfcc544ec15bb7f89a7 100644
--- a/tools/binary_size/libsupersize/describe.py
+++ b/tools/binary_size/libsupersize/describe.py
@@ -175,19 +175,19 @@ class Describer(object):
group_desc)
def _DescribeSizeInfoDiff(self, diff):
- common_metadata = {k: v for k, v in diff.old_metadata.iteritems()
- if diff.new_metadata[k] == v}
- old_metadata = {k: v for k, v in diff.old_metadata.iteritems()
- if k not in common_metadata}
- new_metadata = {k: v for k, v in diff.new_metadata.iteritems()
- if k not in common_metadata}
+ common_metadata = {k: v for k, v in diff.before_metadata.iteritems()
+ if diff.after_metadata[k] == v}
+ before_metadata = {k: v for k, v in diff.before_metadata.iteritems()
+ if k not in common_metadata}
+ after_metadata = {k: v for k, v in diff.after_metadata.iteritems()
+ if k not in common_metadata}
metadata_desc = itertools.chain(
('Common Metadata:',),
(' %s' % line for line in DescribeMetadata(common_metadata)),
('Old Metadata:',),
- (' %s' % line for line in DescribeMetadata(old_metadata)),
+ (' %s' % line for line in DescribeMetadata(before_metadata)),
('New Metadata:',),
- (' %s' % line for line in DescribeMetadata(new_metadata)))
+ (' %s' % line for line in DescribeMetadata(after_metadata)))
section_desc = self._DescribeSectionSizes(diff.section_sizes)
group_desc = self.GenerateLines(diff.symbols)
return itertools.chain(metadata_desc, section_desc, ('',), group_desc)
« no previous file with comments | « tools/binary_size/libsupersize/console.py ('k') | tools/binary_size/libsupersize/integration_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698