Chromium Code Reviews
Help | Chromium Project | Sign in
(67)

Issue 2817783004: Simplify the construction of RemoteTextInputClient (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 3 days ago by tonikitoo
Modified:
2 weeks, 3 days ago
Reviewers:
msw
CC:
chromium-reviews, tfarina, msisov
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify the construction of RemoteTextInputClient Today, RemoteTextInputClient's ctor take six arguments, all extracted manually from a ui::mojom::StartSessionDetailsPtr. In order to simplify its construction, pass ui::mojom::StartSessionDetailsPtr as a parameter to RemoteTextInputClient's ctor and extract data from there. BUG=None

Patch Set 1 #

Messages

Total messages: 8 (6 generated)
tonikitoo
Quick driven-by clean up. PTAL
2 weeks, 3 days ago (2017-04-12 21:57:30 UTC) #5
tonikitoo
2 weeks, 3 days ago (2017-04-12 22:04:30 UTC) #8
On 2017/04/12 21:57:30, tonikitoo wrote:
> Quick driven-by clean up.
> 
> PTAL

Actually, tests pass arguments one by one. so it seems worth it to keep it as
is. Revoking review for now.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46