Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 2817783004: Simplify the construction of RemoteTextInputClient (Closed)

Created:
9 months, 1 week ago by tonikitoo
Modified:
9 months, 1 week ago
Reviewers:
msw
CC:
chromium-reviews, tfarina, msisov
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify the construction of RemoteTextInputClient Today, RemoteTextInputClient's ctor take six arguments, all extracted manually from a ui::mojom::StartSessionDetailsPtr. In order to simplify its construction, pass ui::mojom::StartSessionDetailsPtr as a parameter to RemoteTextInputClient's ctor and extract data from there. BUG=None

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -24 lines) Patch
M chrome/browser/ui/views/ime_driver/ime_driver_mus.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/ime_driver/remote_text_input_client.h View 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/ui/views/ime_driver/remote_text_input_client.cc View 1 chunk +7 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (6 generated)
tonikitoo
Quick driven-by clean up. PTAL
9 months, 1 week ago (2017-04-12 21:57:30 UTC) #5
tonikitoo
9 months, 1 week ago (2017-04-12 22:04:30 UTC) #8
On 2017/04/12 21:57:30, tonikitoo wrote:
> Quick driven-by clean up.
> 
> PTAL

Actually, tests pass arguments one by one. so it seems worth it to keep it as
is. Revoking review for now.

Powered by Google App Engine
This is Rietveld 408576698