Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3694)

Unified Diff: chrome/browser/ui/views/ime_driver/ime_driver_mus.cc

Issue 2817783004: Simplify the construction of RemoteTextInputClient (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/ime_driver/remote_text_input_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/ime_driver/ime_driver_mus.cc
diff --git a/chrome/browser/ui/views/ime_driver/ime_driver_mus.cc b/chrome/browser/ui/views/ime_driver/ime_driver_mus.cc
index a4e267ed598118ab209c7de5e88c6f27a6763a23..8c34c1007ad63ce47a62e99eab9e5f17796feab2 100644
--- a/chrome/browser/ui/views/ime_driver/ime_driver_mus.cc
+++ b/chrome/browser/ui/views/ime_driver/ime_driver_mus.cc
@@ -42,15 +42,13 @@ void IMEDriver::Register() {
void IMEDriver::StartSession(int32_t session_id,
ui::mojom::StartSessionDetailsPtr details) {
#if defined(OS_CHROMEOS)
+ ui::mojom::InputMethodRequest request =
+ std::move(details->input_method_request);
std::unique_ptr<RemoteTextInputClient> remote_client =
- base::MakeUnique<RemoteTextInputClient>(
- std::move(details->client), details->text_input_type,
- details->text_input_mode, details->text_direction,
- details->text_input_flags, details->caret_bounds);
+ base::MakeUnique<RemoteTextInputClient>(std::move(details));
input_method_bindings_[session_id] =
base::MakeUnique<mojo::Binding<ui::mojom::InputMethod>>(
- new InputMethodBridge(std::move(remote_client)),
- std::move(details->input_method_request));
+ new InputMethodBridge(std::move(remote_client)), std::move(request));
#else
input_method_bindings_[session_id] =
base::MakeUnique<mojo::Binding<ui::mojom::InputMethod>>(
« no previous file with comments | « no previous file | chrome/browser/ui/views/ime_driver/remote_text_input_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698