Chromium Code Reviews
DescriptionRevert of [Reland] Use dropdown list for admin areas in pr form. (patchset #2 id:40001 of https://codereview.chromium.org/2812893002/ )
Reason for revert:
Still some lingering test failures. See crbug.com/710911
Original issue's description:
> Reland explanation: crrev.com/2680143002 caused chrome_public_test_apk
> failing on chromium.android/Marshmallow. The problem is fixed in this
> CL.
>
> To make the payment request tests independent of the network status,
> the tests set the time-out = 0,
> which means that the sub-keys must never be fetched,
> and the address forms will always show a textfield,
> and not a dropdown for the admin areas.
>
> In the previous CL, the time-out would start after the request.
> => For some entities (with network connection),
> subkeys were already fetched, before the timeout had started.
> => A dropdown would show.
>
> To solve this, the order was changed.
> Now the time-out starts before the request.
>
>
> BUG=709491
>
> Review-Url: https://codereview.chromium.org/2812893002
> Cr-Commit-Position: refs/heads/master@{#463945}
> Committed: https://chromium.googlesource.com/chromium/src/+/886089f3cad28e46fa21e3d73c60fd5e87d7621f
TBR=mathp@chromium.org,sebsg@chromium.org,rouslan@chromium.org,dfalcantara@chromium.org,parastoog@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=709491
Review-Url: https://codereview.chromium.org/2817733002
Cr-Commit-Position: refs/heads/master@{#464069}
Committed: https://chromium.googlesource.com/chromium/src/+/8ce1b3a5c77dbe359a1592acb9bcfbadf3339bf0
Patch Set 1 #Messages
Total messages: 6 (3 generated)
|