Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2817733002: Revert of [Reland] Use dropdown list for admin areas in pr form. (Closed)

Created:
3 years, 8 months ago by Donn Denman
Modified:
3 years, 8 months ago
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Reland] Use dropdown list for admin areas in pr form. (patchset #2 id:40001 of https://codereview.chromium.org/2812893002/ ) Reason for revert: Still some lingering test failures. See crbug.com/710911 Original issue's description: > Reland explanation: crrev.com/2680143002 caused chrome_public_test_apk > failing on chromium.android/Marshmallow. The problem is fixed in this > CL. > > To make the payment request tests independent of the network status, > the tests set the time-out = 0, > which means that the sub-keys must never be fetched, > and the address forms will always show a textfield, > and not a dropdown for the admin areas. > > In the previous CL, the time-out would start after the request. > => For some entities (with network connection), > subkeys were already fetched, before the timeout had started. > => A dropdown would show. > > To solve this, the order was changed. > Now the time-out starts before the request. > > > BUG=709491 > > Review-Url: https://codereview.chromium.org/2812893002 > Cr-Commit-Position: refs/heads/master@{#463945} > Committed: https://chromium.googlesource.com/chromium/src/+/886089f3cad28e46fa21e3d73c60fd5e87d7621f TBR=mathp@chromium.org,sebsg@chromium.org,rouslan@chromium.org,dfalcantara@chromium.org,parastoog@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=709491 Review-Url: https://codereview.chromium.org/2817733002 Cr-Commit-Position: refs/heads/master@{#464069} Committed: https://chromium.googlesource.com/chromium/src/+/8ce1b3a5c77dbe359a1592acb9bcfbadf3339bf0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -485 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java View 8 chunks +11 lines, -64 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java View 11 chunks +60 lines, -163 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java View 4 chunks +1 line, -10 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java View 2 chunks +1 line, -12 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileBridge.java View 1 chunk +1 line, -22 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/android/personal_data_manager_android.h View 4 chunks +2 lines, -52 lines 0 comments Download
M chrome/browser/autofill/android/personal_data_manager_android.cc View 6 chunks +3 lines, -98 lines 0 comments Download
M components/payments/core/address_normalizer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/payments/core/address_normalizer.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/libaddressinput/chromium/chrome_address_validator.h View 2 chunks +2 lines, -9 lines 0 comments Download
M third_party/libaddressinput/chromium/chrome_address_validator.cc View 4 chunks +1 line, -17 lines 0 comments Download
M third_party/libaddressinput/chromium/chrome_address_validator_unittest.cc View 7 chunks +8 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Donn Denman
Created Revert of [Reland] Use dropdown list for admin areas in pr form.
3 years, 8 months ago (2017-04-12 17:20:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817733002/1
3 years, 8 months ago (2017-04-12 17:21:48 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 17:34:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8ce1b3a5c77dbe359a1592acb9bc...

Powered by Google App Engine
This is Rietveld 408576698